Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 517273003: Cherry pick r573 from upstream protobuf (Closed)

Created:
6 years, 3 months ago by gordanac
Modified:
6 years, 3 months ago
Reviewers:
brettw, gordanac
CC:
chromium-reviews, Paul Lind, petar.jovanovic
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Cherry pick r573 from upstream protobuf Add mips64 atomicops to protobuf. BUG=400684 Committed: https://crrev.com/83552e7ef665488bc0f4eb0be5bec5921eedea19 Cr-Commit-Position: refs/heads/master@{#293110}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -3 lines) Patch
M third_party/protobuf/README.chromium View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/protobuf/src/google/protobuf/stubs/atomicops.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/protobuf/src/google/protobuf/stubs/atomicops_internals_mips_gcc.h View 3 chunks +128 lines, -2 lines 0 comments Download
M third_party/protobuf/src/google/protobuf/stubs/platform_macros.h View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
gordanac
Please take a look.
6 years, 3 months ago (2014-09-01 15:15:23 UTC) #2
brettw
lgtm
6 years, 3 months ago (2014-09-02 23:40:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/Gordana.Cmiljanovic@imgtec.com/517273003/1
6 years, 3 months ago (2014-09-03 08:19:55 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel_swarming on tryserver.chromium.win ...
6 years, 3 months ago (2014-09-03 09:27:28 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 67c6c3917f6ba7613d91e72cddf467528a52f0f4
6 years, 3 months ago (2014-09-03 10:13:39 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:24:50 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/83552e7ef665488bc0f4eb0be5bec5921eedea19
Cr-Commit-Position: refs/heads/master@{#293110}

Powered by Google App Engine
This is Rietveld 408576698