Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 517213002: [fsp] Move thumbnail logic to Drive specific C++ code. (Closed)

Created:
6 years, 3 months ago by mtomasz
Modified:
6 years, 3 months ago
Reviewers:
hirono
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, yoshiki+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[fsp] Move thumbnail logic to Drive specific C++ code. MetadataCache is soon going to be generalized from Drive to also FSP file systems. So, in the Files app layer, we should not have Drive specific code. TEST=Tested manually. BUG=408017 Committed: https://crrev.com/ca54e1562467d112b8e496dc7dfbcaaf63567367 Cr-Commit-Position: refs/heads/master@{#292829}

Patch Set 1 #

Patch Set 2 : Fixed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -8 lines) Patch
M chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc View 1 chunk +4 lines, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/thumbnail_loader.js View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mtomasz
@hirono: PTAL at this tiny patch. Thanks.
6 years, 3 months ago (2014-09-01 02:56:44 UTC) #2
hirono
lgtm, thanks!
6 years, 3 months ago (2014-09-01 03:25:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/517213002/20001
6 years, 3 months ago (2014-09-01 03:26:13 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 6423dfc98b2c7765464dd922729a1f536e70e9a6
6 years, 3 months ago (2014-09-01 03:50:16 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:15:27 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ca54e1562467d112b8e496dc7dfbcaaf63567367
Cr-Commit-Position: refs/heads/master@{#292829}

Powered by Google App Engine
This is Rietveld 408576698