Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 517193003: More System Dialog printing code disabled on Windows. (Closed)

Created:
6 years, 3 months ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years, 3 months ago
Reviewers:
Lei Zhang, jschuh
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@522493002
Project:
chromium
Visibility:
Public.

Description

More System Dialog printing code disabled on Windows. BUG=374321 Committed: https://chromium.googlesource.com/chromium/src/+/77daf4022522fd889f31fe8cb6abb33c45a54857 Committed: https://crrev.com/f9433e4d9c4fde723a1e791e63ad3c67308ef95d Cr-Commit-Position: refs/heads/master@{#293700}

Patch Set 1 #

Patch Set 2 : Fri Aug 29 01:30:01 PDT 2014 #

Patch Set 3 : Fri Aug 29 14:38:15 PDT 2014 #

Patch Set 4 : Mon Sep 8 00:30:40 PDT 2014 #

Patch Set 5 : Mon Sep 8 01:10:20 PDT 2014 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -50 lines) Patch
M build/common.gypi View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/app/chrome_command_ids.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/chrome_dll.rc View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/printing/print_view_manager.h View 1 2 3 4 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/printing/print_view_manager.cc View 1 2 3 4 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/printing/print_view_manager_base.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/printing/print_view_manager_base.cc View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser_command_controller.cc View 1 2 3 4 2 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/ui/browser_commands.h View 1 2 3 4 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/browser_commands.cc View 1 2 3 4 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/accelerators_cocoa.mm View 1 2 3 4 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/ui/views/accelerator_table.cc View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_handler.h View 1 2 3 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_handler.cc View 1 2 3 4 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_ui.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_ui.cc View 1 2 3 4 3 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_ui_browsertest.cc View 1 2 3 4 2 chunks +10 lines, -10 lines 0 comments Download
M chrome/common/print_messages.h View 1 2 3 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/renderer/printing/print_web_view_helper.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/renderer/printing/print_web_view_helper.cc View 1 2 3 5 chunks +6 lines, -1 line 0 comments Download
M chrome/renderer/printing/print_web_view_helper_browsertest.cc View 1 2 3 6 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 21 (6 generated)
Vitaly Buka (NO REVIEWS)
vitalybuka@chromium.org changed reviewers: + thestig@chromium.org
6 years, 3 months ago (2014-08-29 08:26:05 UTC) #1
Vitaly Buka (NO REVIEWS)
6 years, 3 months ago (2014-08-29 08:26:05 UTC) #2
Vitaly Buka (NO REVIEWS)
vitalybuka@chromium.org changed reviewers: + jschuh@chromium.org
6 years, 3 months ago (2014-08-29 08:27:22 UTC) #3
Vitaly Buka (NO REVIEWS)
jschuh: chrome/common/print_messages.h
6 years, 3 months ago (2014-08-29 08:27:22 UTC) #4
Lei Zhang
lgtm
6 years, 3 months ago (2014-08-29 15:29:23 UTC) #5
jschuh
ipc security lgtm
6 years, 3 months ago (2014-08-29 21:50:46 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_clang_dbg_recipe on tryserver.chromium.linux ...
6 years, 3 months ago (2014-08-30 01:05:55 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 77daf4022522fd889f31fe8cb6abb33c45a54857
6 years, 3 months ago (2014-08-30 01:32:21 UTC) #9
Vitaly Buka (NO REVIEWS)
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/546373002/ by vitalybuka@chromium.org. ...
6 years, 3 months ago (2014-09-08 07:08:56 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/517193003/60001
6 years, 3 months ago (2014-09-08 07:39:48 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/517193003/80001
6 years, 3 months ago (2014-09-08 08:16:13 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/517193003/80001
6 years, 3 months ago (2014-09-08 08:52:19 UTC) #18
commit-bot: I haz the power
Committed patchset #5 (id:80001) as eefab396f9b21357810a1193d9f3df32c8127749
6 years, 3 months ago (2014-09-08 10:05:53 UTC) #19
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/055d6ed0f21f8c773f532e3b1fd974de7b8c0f35 Cr-Commit-Position: refs/heads/master@{#292747}
6 years, 3 months ago (2014-09-10 03:12:47 UTC) #20
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:45:31 UTC) #21
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/f9433e4d9c4fde723a1e791e63ad3c67308ef95d
Cr-Commit-Position: refs/heads/master@{#293700}

Powered by Google App Engine
This is Rietveld 408576698