Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Issue 517193002: Use correct font for label in a drag image (Closed)

Created:
6 years, 3 months ago by Mikus
Modified:
6 years, 3 months ago
Reviewers:
eae
CC:
blink-reviews, dcheng
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Use correct font for label in a drag image The drag image, generated when dragging a link from web contents is using the same font for both the title and its link, even though different fonts (bold and regular) are created for those two elements (accordingly). This change makes the title use the bold font as it is supposed to do. R=eae@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181293

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Source/platform/DragImage.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
Mikus
mboc@opera.com changed reviewers: + eae@chromium.org
6 years, 3 months ago (2014-08-29 06:31:43 UTC) #1
Mikus
On 2014/08/29 06:31:43, Mikus wrote: > mailto:mboc@opera.com changed reviewers: > + mailto:eae@chromium.org If we create ...
6 years, 3 months ago (2014-08-29 06:32:22 UTC) #2
Mikus
6 years, 3 months ago (2014-08-29 06:32:27 UTC) #3
eae
Change itself looks good but I'd like to see a better change description.
6 years, 3 months ago (2014-08-29 15:46:33 UTC) #4
Mikus
On 2014/08/29 15:46:33, eae wrote: > Change itself looks good but I'd like to see ...
6 years, 3 months ago (2014-09-01 07:29:17 UTC) #5
eae
Thanks. LGTM
6 years, 3 months ago (2014-09-02 14:57:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mboc@opera.com/517193002/1
6 years, 3 months ago (2014-09-03 07:05:06 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-03 08:05:09 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181293

Powered by Google App Engine
This is Rietveld 408576698