Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 517153002: Re-enalbe "testSetGetBackgroundColor" (Closed)

Created:
6 years, 3 months ago by hush (inactive)
Modified:
6 years, 3 months ago
Reviewers:
boliu
CC:
chromium-reviews, android-webview-reviews_chromium.org, Ignacio Solla
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Re-enalbe "testSetGetBackgroundColor" Background color issue should already be fixed by crbug.com/391462 BUG=384559 Committed: https://crrev.com/8d684e3f2775bd978fc003c6cd343b40caf13bbf Cr-Commit-Position: refs/heads/master@{#292540}

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : Bo's comments #

Total comments: 3

Patch Set 4 : #

Patch Set 5 : yay #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsRenderTest.java View 1 2 3 4 3 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
hush (inactive)
hush@chromium.org changed reviewers: + boliu@chromium.org
6 years, 3 months ago (2014-08-28 23:31:02 UTC) #1
hush (inactive)
it passes pretty consistently PTAL.
6 years, 3 months ago (2014-08-28 23:31:02 UTC) #2
boliu
lgtm, although there are some existing issues https://codereview.chromium.org/517153002/diff/20001/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsRenderTest.java File android_webview/javatests/src/org/chromium/android_webview/test/AwContentsRenderTest.java (right): https://codereview.chromium.org/517153002/diff/20001/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsRenderTest.java#newcode79 android_webview/javatests/src/org/chromium/android_webview/test/AwContentsRenderTest.java:79: assertEquals(Color.CYAN, sampleBackgroundColorOnUiThread()); ...
6 years, 3 months ago (2014-08-28 23:35:53 UTC) #3
hush (inactive)
https://codereview.chromium.org/517153002/diff/20001/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsRenderTest.java File android_webview/javatests/src/org/chromium/android_webview/test/AwContentsRenderTest.java (right): https://codereview.chromium.org/517153002/diff/20001/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsRenderTest.java#newcode79 android_webview/javatests/src/org/chromium/android_webview/test/AwContentsRenderTest.java:79: assertEquals(Color.CYAN, sampleBackgroundColorOnUiThread()); On 2014/08/28 23:35:53, boliu wrote: > This ...
6 years, 3 months ago (2014-08-28 23:56:53 UTC) #4
boliu
https://codereview.chromium.org/517153002/diff/40001/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsRenderTest.java File android_webview/javatests/src/org/chromium/android_webview/test/AwContentsRenderTest.java (right): https://codereview.chromium.org/517153002/diff/40001/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsRenderTest.java#newcode91 android_webview/javatests/src/org/chromium/android_webview/test/AwContentsRenderTest.java:91: pollForBackgroundColor(Color.rgb(0x22, 0x77, 0x88)); This one is fine. It's not ...
6 years, 3 months ago (2014-08-28 23:58:23 UTC) #5
boliu
https://codereview.chromium.org/517153002/diff/40001/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsRenderTest.java File android_webview/javatests/src/org/chromium/android_webview/test/AwContentsRenderTest.java (right): https://codereview.chromium.org/517153002/diff/40001/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsRenderTest.java#newcode79 android_webview/javatests/src/org/chromium/android_webview/test/AwContentsRenderTest.java:79: pollForBackgroundColor(Color.CYAN); oh actually I take it back, this one ...
6 years, 3 months ago (2014-08-29 00:12:47 UTC) #6
hush (inactive)
https://codereview.chromium.org/517153002/diff/40001/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsRenderTest.java File android_webview/javatests/src/org/chromium/android_webview/test/AwContentsRenderTest.java (right): https://codereview.chromium.org/517153002/diff/40001/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsRenderTest.java#newcode79 android_webview/javatests/src/org/chromium/android_webview/test/AwContentsRenderTest.java:79: pollForBackgroundColor(Color.CYAN); On 2014/08/29 00:12:46, boliu wrote: > oh actually ...
6 years, 3 months ago (2014-08-29 00:18:01 UTC) #7
hush (inactive)
The CQ bit was checked by hush@chromium.org
6 years, 3 months ago (2014-08-29 00:18:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hush@chromium.org/517153002/80001
6 years, 3 months ago (2014-08-29 00:19:46 UTC) #9
commit-bot: I haz the power
Committed patchset #5 (id:80001) as e65eaa92712379c36149ef20770361eb6c7d8082
6 years, 3 months ago (2014-08-29 01:34:42 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:04:59 UTC) #11
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/8d684e3f2775bd978fc003c6cd343b40caf13bbf
Cr-Commit-Position: refs/heads/master@{#292540}

Powered by Google App Engine
This is Rietveld 408576698