Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issue 517143003: Hide NativeViewHostAura correctly. (Closed)

Created:
6 years, 3 months ago by calamity
Modified:
6 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Hide NativeViewHostAura correctly. This CL fixes an issue where the NativeViewHostAura clipping window would not be hidden correctly and steal mouse events from the experimental app list. This CL simply hides the clipping window when the NativeViewHost is hidden. BUG=408877 Committed: https://crrev.com/d17e39e5f243fe62d0ea0f0bf1a56549a524a950 Cr-Commit-Position: refs/heads/master@{#293125}

Patch Set 1 #

Patch Set 2 : add test #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M ui/views/controls/native/native_view_host_aura.cc View 1 chunk +1 line, -0 lines 2 comments Download
M ui/views/controls/native/native_view_host_aura_unittest.cc View 1 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
calamity
calamity@chromium.org changed reviewers: + sky@chromium.org
6 years, 3 months ago (2014-08-29 01:48:42 UTC) #1
calamity
6 years, 3 months ago (2014-08-29 01:48:42 UTC) #2
sky
LGTM https://codereview.chromium.org/517143003/diff/20001/ui/views/controls/native/native_view_host_aura.cc File ui/views/controls/native/native_view_host_aura.cc (right): https://codereview.chromium.org/517143003/diff/20001/ui/views/controls/native/native_view_host_aura.cc#newcode167 ui/views/controls/native/native_view_host_aura.cc:167: host_->native_view()->Hide(); We may not need the Hide/Show on ...
6 years, 3 months ago (2014-09-02 15:19:38 UTC) #3
calamity
https://codereview.chromium.org/517143003/diff/20001/ui/views/controls/native/native_view_host_aura.cc File ui/views/controls/native/native_view_host_aura.cc (right): https://codereview.chromium.org/517143003/diff/20001/ui/views/controls/native/native_view_host_aura.cc#newcode167 ui/views/controls/native/native_view_host_aura.cc:167: host_->native_view()->Hide(); On 2014/09/02 15:19:37, sky wrote: > We may ...
6 years, 3 months ago (2014-09-03 00:44:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/calamity@chromium.org/517143003/20001
6 years, 3 months ago (2014-09-03 11:22:06 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as eee179bbddf57a56a64b55c316f434311a69c287
6 years, 3 months ago (2014-09-03 12:18:02 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:25:23 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d17e39e5f243fe62d0ea0f0bf1a56549a524a950
Cr-Commit-Position: refs/heads/master@{#293125}

Powered by Google App Engine
This is Rietveld 408576698