Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(820)

Issue 517143002: Revert of Revert of Fix assorted issues with remote CoreAnimation (Closed)

Created:
6 years, 3 months ago by ccameron
Modified:
6 years, 3 months ago
Reviewers:
epenner, piman
CC:
chromium-reviews, Ian Vollick, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@clean_up_accel_layers
Project:
chromium
Visibility:
Public.

Description

Revert of Revert of Fix assorted issues with remote CoreAnimation (patchset #1 of https://codereview.chromium.org/517733002/) Reason for revert: Patch was reverted in error Original issue's description: > Revert of Fix assorted issues with remote CoreAnimation (patchset #2 of https://codereview.chromium.org/516643002/) > > Reason for revert: > Speculatively reverting to see if this helps the mac perf bots: > https://code.google.com/p/chromium/issues/detail?id=408673 > > Original issue's description: > > Fix assorted issues with remote CoreAnimation > > > > These issues came up while running for a few days with the > > flag --enable-remote-core-animation. > > > > Fix flashes of old frames by hooking up the DiscardBackbuffer (which > > happens when being made non-visible) to re-set the CAContext and > > CALayer (so the browser gets a new one with new content for the next > > frame). > > > > Add support for disabling vsync by using setNeedsDisplay to draw. > > > > Change the backpressure mechanism to rely on the browser to apply > > backpressure in its compositor via the cc:: output surface. > > > > Add a ScopedSetGLToRealGLApi structure to ensure that we are talking > > to the real GL API while in the CoreAnimation callback. > > > > BUG=312462 > > > > Committed: https://chromium.googlesource.com/chromium/src/+/3b6aee8ed0393d852ed21fae78f539ffffe3e8f8 > > TBR=piman@chromium.org,ccameron@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=312462 > > Committed: https://chromium.googlesource.com/chromium/src/+/07539c445c9fa7161b3da9031cf440a2b657dd18 TBR=piman@chromium.org,epenner@chromium.org NOTREECHECKS=true NOTRY=true BUG=312462 Committed: https://crrev.com/18bbc2ab2660ec4ac9ddbd0d2367d9e3886ce136 Cr-Commit-Position: refs/heads/master@{#292481}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+209 lines, -102 lines) Patch
M content/browser/compositor/browser_compositor_view_private_mac.mm View 3 chunks +3 lines, -0 lines 0 comments Download
M content/common/gpu/image_transport_surface_calayer_mac.h View 2 chunks +14 lines, -3 lines 0 comments Download
M content/common/gpu/image_transport_surface_calayer_mac.mm View 8 chunks +113 lines, -38 lines 0 comments Download
M content/common/gpu/image_transport_surface_fbo_mac.h View 3 chunks +17 lines, -19 lines 0 comments Download
M content/common/gpu/image_transport_surface_fbo_mac.mm View 5 chunks +20 lines, -32 lines 0 comments Download
M content/common/gpu/image_transport_surface_iosurface_mac.h View 1 chunk +4 lines, -3 lines 0 comments Download
M content/common/gpu/image_transport_surface_iosurface_mac.cc View 1 chunk +12 lines, -7 lines 0 comments Download
M ui/compositor/compositor.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/compositor/compositor.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/gl/gl_gl_api_implementation.h View 2 chunks +10 lines, -0 lines 0 comments Download
M ui/gl/gl_gl_api_implementation.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ccameron
Created Revert of Revert of Fix assorted issues with remote CoreAnimation
6 years, 3 months ago (2014-08-28 22:33:29 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/517143002/1
6 years, 3 months ago (2014-08-28 22:35:06 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 27fa6f79cf7515109b470ef6212c2b49babcac94
6 years, 3 months ago (2014-08-28 22:36:43 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:02:52 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/18bbc2ab2660ec4ac9ddbd0d2367d9e3886ce136
Cr-Commit-Position: refs/heads/master@{#292481}

Powered by Google App Engine
This is Rietveld 408576698