Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 517133002: Update LSAN suppressions. (Closed)

Created:
6 years, 3 months ago by mtklein_C
Modified:
6 years, 3 months ago
Reviewers:
mtklein, robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Update LSAN suppressions. Seems the obvious thing works now. Ran nanobench, ----------------------------------------------------- Suppressions used: count bytes template 586 3530064 libGL.so ----------------------------------------------------- and dm, ----------------------------------------------------- Suppressions used: count bytes template 340 2048160 libGL.so ----------------------------------------------------- BUG=skia: Committed: https://skia.googlesource.com/skia/+/970e106b883a7b52155b94d01437dfb8ee1eb1e3

Patch Set 1 #

Patch Set 2 : space #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -12 lines) Patch
M Makefile View 1 chunk +1 line, -1 line 0 comments Download
M tools/lsan.supp View 1 1 chunk +4 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
mtklein
mtklein@google.com changed reviewers: + mtklein@google.com, robertphillips@google.com
6 years, 3 months ago (2014-08-28 22:30:26 UTC) #1
mtklein
Will enable this on the ASAN bots if this LGTY.
6 years, 3 months ago (2014-08-28 22:30:26 UTC) #2
robertphillips
lgtm
6 years, 3 months ago (2014-08-29 14:01:10 UTC) #3
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 3 months ago (2014-08-29 14:09:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/517133002/20001
6 years, 3 months ago (2014-08-29 14:09:22 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-08-29 14:55:39 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 970e106b883a7b52155b94d01437dfb8ee1eb1e3

Powered by Google App Engine
This is Rietveld 408576698