Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(653)

Issue 517123004: [turbofan] Use enum instead of bool for parameter. (Closed)

Created:
6 years, 3 months ago by Benedikt Meurer
Modified:
6 years, 3 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] Use enum instead of bool for parameter. TEST=compiler-unittests R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23509

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M src/compiler/change-lowering.h View 2 chunks +3 lines, -1 line 0 comments Download
M src/compiler/change-lowering.cc View 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Benedikt Meurer
bmeurer@chromium.org changed reviewers: + svenpanne@chromium.org
6 years, 3 months ago (2014-08-29 05:11:48 UTC) #1
Benedikt Meurer
Cosmetic fix, PTAL
6 years, 3 months ago (2014-08-29 05:11:48 UTC) #2
Sven Panne
lgtm
6 years, 3 months ago (2014-08-29 06:40:11 UTC) #3
Benedikt Meurer
6 years, 3 months ago (2014-08-29 06:42:51 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as 23509 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698