Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 517113002: Revert of Revert of Revert of add gamma/sRGB to SkImageInfo (Closed)

Created:
6 years, 3 months ago by reed1
Modified:
6 years, 3 months ago
Reviewers:
bungeman-skia, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Revert of Revert of Revert of add gamma/sRGB to SkImageInfo (patchset #1 of https://codereview.chromium.org/511363002/) Reason for revert: android builder in chrome reveals the caller using { } initialization for SkImageInfo, which this CL now makes illegal. Will have to fix the call site before I can re-land this Original issue's description: > Revert of Revert of add gamma/sRGB to SkImageInfo (patchset #1 of https://codereview.chromium.org/512243002/) > > Reason for revert: > this revert was premature -- the chrome canary I looked at is old, and newer ones were green. So trying again... > > Original issue's description: > > Revert of add gamma/sRGB to SkImageInfo (patchset #4 of https://codereview.chromium.org/514753002/) > > > > Reason for revert: > > breaks linker on chrome -- may need SK_API, but not sure. > > > > Original issue's description: > > > add gamma/sRGB to SkImageInfo > > > > > > BUG=skia: > > > > > > Committed: https://skia.googlesource.com/skia/+/615c369777258231054840a88cdb74c68c382485 > > > > TBR=bungeman@google.com,bsalomon@google.com > > NOTREECHECKS=true > > NOTRY=true > > BUG=skia: > > > > Committed: https://skia.googlesource.com/skia/+/dc53701216c0e9f98eacf6c0cda769ebbd200b59 > > TBR=bungeman@google.com,bsalomon@google.com > NOTREECHECKS=true > NOTRY=true > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/e759a2662273fdf52ebbb3822229945eda317e46 TBR=bungeman@google.com,bsalomon@google.com NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/088f4b8eb31b2af26e66dcbaae062f40b3955059

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -240 lines) Patch
M gyp/tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M include/core/SkImageInfo.h View 4 chunks +24 lines, -64 lines 0 comments Download
M src/core/SkImageInfo.cpp View 2 chunks +21 lines, -111 lines 0 comments Download
D tests/ImageInfoTest.cpp View 1 chunk +0 lines, -64 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
reed1
Created Revert of Revert of Revert of add gamma/sRGB to SkImageInfo
6 years, 3 months ago (2014-08-28 21:45:29 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/517113002/1
6 years, 3 months ago (2014-08-28 21:46:10 UTC) #2
commit-bot: I haz the power
6 years, 3 months ago (2014-08-28 21:46:24 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 088f4b8eb31b2af26e66dcbaae062f40b3955059

Powered by Google App Engine
This is Rietveld 408576698