ui/views/widget/desktop_aura/desktop_native_widget_aura.cc - Issue 517103003: Aura: Don't activate menus and other non-activatable widgets on drop

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/widget/desktop_aura/desktop_native_widget_aura.cc

Issue 517103003: Aura: Don't activate menus and other non-activatable widgets on drop (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/widget/desktop_aura/desktop_native_widget_aura.cc

diff --git a/ui/views/widget/desktop_aura/desktop_native_widget_aura.cc b/ui/views/widget/desktop_aura/desktop_native_widget_aura.cc

index f4875b13eb2db2d5b64a2b23bed7c01173917e29..1a658b1bf4207281241ddf81b17c773d319694cb 100644

--- a/ui/views/widget/desktop_aura/desktop_native_widget_aura.cc

+++ b/ui/views/widget/desktop_aura/desktop_native_widget_aura.cc

@@ -1140,7 +1140,8 @@ void DesktopNativeWidgetAura::OnDragExited() {

int DesktopNativeWidgetAura::OnPerformDrop(const ui::DropTargetEvent& event) {

DCHECK(drop_helper_.get() != NULL);

- Activate();

+ if (ShouldActivate())

+ Activate();

return drop_helper_->OnDrop(event.data(), event.location(),

last_drop_operation_);

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »