net/cert/asn1_util.h - Issue 517083002: Enable Certificate Transparency in the OpenSSL port.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/cert/asn1_util.h

Issue 517083002: Enable Certificate Transparency in the OpenSSL port. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ct-objects-extractor

Patch Set: hopefully fix NaCl build Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/cert/asn1_util.h

diff --git a/net/cert/asn1_util.h b/net/cert/asn1_util.h

index ed379b3f1223cf9f2cf2aa92fd71082f22c80edc..3c47bd862edb647c91cb90106bbdbe97bae3188a 100644

--- a/net/cert/asn1_util.h

+++ b/net/cert/asn1_util.h

@@ -20,6 +20,7 @@ static const unsigned kINTEGER = 0x02;

static const unsigned kBITSTRING = 0x03;

static const unsigned kOCTETSTRING = 0x04;

static const unsigned kOID = 0x06;

+static const unsigned kENUMERATED = 0x0a;

Ryan Sleevi 2014/09/02 19:49:06 Pure pedantry nit: 0x0A; You can send me hate-mai

davidben 2014/09/02 22:13:45 Done.

static const unsigned kSEQUENCE = 0x30;

// These are flags that can be ORed with the above tag numbers.

@@ -53,9 +54,9 @@ bool ParseElement(base::StringPiece* in,

// If |tag_value & kOptional| is true then this function cannot distinguish

// between a missing optional element and an empty one.

-bool GetElement(base::StringPiece* in,

- unsigned tag_value,

- base::StringPiece* out);

+NET_EXPORT_PRIVATE bool GetElement(base::StringPiece* in,

+ unsigned tag_value,

+ base::StringPiece* out);

// ExtractSPKIFromDERCert parses the DER encoded certificate in |cert| and

// extracts the bytes of the SubjectPublicKeyInfo. On successful return,

« no previous file with comments | « chrome/browser/io_thread.cc ('k') | net/net.gypi » ('j') | net/socket/ssl_client_socket_openssl.cc » ('J')