Issue 517073002: Align all SkRecord::alloc() calls up to at least a pointer size.

Issue 517073002: Align all SkRecord::alloc() calls up to at least a pointer size. (Closed)

Created:
6 years, 3 months ago by mtklein_C

Modified:
6 years, 3 months ago

Reviewers:
mtklein, robertphillips, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Align all SkRecord::alloc() calls up to at least a pointer size. This should make the LSAN bots able to see all our pointers. BUG=skia: Committed: https://skia.googlesource.com/skia/+/0209e95cc2625a445c1cb6c4213d2182e5c832d7

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -1 line)			Patch
M	include/core/SkTypes.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/core/SkRecord.h	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	tests/RecordTest.cpp	View		1 chunk	+25 lines, -0 lines	0 comments	Download

Total messages: 8 (0 generated)

mtklein

mtklein@google.com changed reviewers: + mtklein@google.com, reed@google.com, robertphillips@google.com

6 years, 3 months ago (2014-08-28 20:13:47 UTC) #1

mtklein

Testing browser_tests with LSAN locally now. So far so good. Can't really test with Chrome's ...

6 years, 3 months ago (2014-08-28 20:13:47 UTC) #2

reed1

lgtm - request we add SkAlign... to SkTypes.h SkAlignPtr? SkAlignIntPtrT? other?

6 years, 3 months ago (2014-08-28 20:24:29 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/517073002/20001

6 years, 3 months ago (2014-08-28 20:58:50 UTC) #7

commit-bot: I haz the power

6 years, 3 months ago (2014-08-28 21:10:08 UTC) #8

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as 0209e95cc2625a445c1cb6c4213d2182e5c832d7