Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Issue 517053002: Fix athena_unittests dependency (Closed)

Created:
6 years, 3 months ago by pkotwicz
Modified:
6 years, 3 months ago
Reviewers:
oshima
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix athena_unittests dependency BUG=None TEST=athena_unittests run again Committed: https://crrev.com/56c93e40fb94e858920e4ae5177b743e3c506738 Cr-Commit-Position: refs/heads/master@{#292510}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M athena/athena.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
pkotwicz
pkotwicz@chromium.org changed reviewers: + oshima@chromium.org
6 years, 3 months ago (2014-08-28 20:04:56 UTC) #1
pkotwicz
Patchset #2 (id:20001) has been deleted
6 years, 3 months ago (2014-08-28 20:05:05 UTC) #2
pkotwicz
Patchset #1 (id:1) has been deleted
6 years, 3 months ago (2014-08-28 20:05:09 UTC) #3
pkotwicz
Oshima, PTAL
6 years, 3 months ago (2014-08-28 20:05:48 UTC) #4
oshima
lgtm
6 years, 3 months ago (2014-08-28 20:28:00 UTC) #5
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 3 months ago (2014-08-28 21:48:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/517053002/40001
6 years, 3 months ago (2014-08-28 21:49:18 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel_swarming on tryserver.chromium.win ...
6 years, 3 months ago (2014-08-28 23:10:15 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:40001) as cf8a85c36f2c803e07c3af396a1068a25c27e520
6 years, 3 months ago (2014-08-29 00:00:35 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:03:59 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/56c93e40fb94e858920e4ae5177b743e3c506738
Cr-Commit-Position: refs/heads/master@{#292510}

Powered by Google App Engine
This is Rietveld 408576698