Source/web/WebTextCheckingCompletionImpl.h - Issue 517043003: Move Frame to the Oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebTextCheckingCompletionImpl.h

Issue 517043003: Move Frame to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Back out non-Oilpan experiment + tidy up by adding frame() ref accessors Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/WebTextCheckingCompletionImpl.h

diff --git a/Source/web/WebTextCheckingCompletionImpl.h b/Source/web/WebTextCheckingCompletionImpl.h

index ca4b3b5250f09cef91966d960d4cf514b2225d07..e1c8bc253b8f0368949bcf77ece950b96d2bcf1c 100644

--- a/Source/web/WebTextCheckingCompletionImpl.h

+++ b/Source/web/WebTextCheckingCompletionImpl.h

@@ -31,6 +31,7 @@

#ifndef WebTextCheckingCompletionImpl_h

#define WebTextCheckingCompletionImpl_h

+#include "platform/heap/Handle.h"

#include "platform/text/TextChecking.h"

#include "public/web/WebTextCheckingCompletion.h"

#include "wtf/RefPtr.h"

@@ -41,7 +42,7 @@ class EditorClientImpl;

class WebTextCheckingCompletionImpl FINAL : public WebTextCheckingCompletion {

public:

- explicit WebTextCheckingCompletionImpl(WTF::PassRefPtr<TextCheckingRequest> request)

+ explicit WebTextCheckingCompletionImpl(PassRefPtrWillBeRawPtr<TextCheckingRequest> request)

: m_request(request)

{

}

@@ -52,7 +53,7 @@ public:

private:

virtual ~WebTextCheckingCompletionImpl() { }

- WTF::RefPtr<TextCheckingRequest> m_request;

+ RefPtrWillBePersistent<TextCheckingRequest> m_request;

};

} // namespace blink