Source/web/WebPluginContainerImpl.cpp - Issue 517043003: Move Frame to the Oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebPluginContainerImpl.cpp

Issue 517043003: Move Frame to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Back out non-Oilpan experiment + tidy up by adding frame() ref accessors Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/WebPluginContainerImpl.cpp

diff --git a/Source/web/WebPluginContainerImpl.cpp b/Source/web/WebPluginContainerImpl.cpp

index 48b9532b61a57e64cf20232acc87fdcb34363d55..4adc15c159fa4b21adddec32ae9ebe0091593cd1 100644

--- a/Source/web/WebPluginContainerImpl.cpp

+++ b/Source/web/WebPluginContainerImpl.cpp

@@ -674,7 +674,11 @@ bool WebPluginContainerImpl::paintCustomOverhangArea(GraphicsContext* context, c

// Private methods -------------------------------------------------------------

WebPluginContainerImpl::WebPluginContainerImpl(HTMLPlugInElement* element, WebPlugin* webPlugin)

+#if ENABLE(OILPAN)

+ : m_frame(element->document().frame())

+#else

: FrameDestructionObserver(element->document().frame())

+#endif

, m_element(element)

, m_webPlugin(webPlugin)

, m_webLayer(0)