Source/core/loader/FrameLoaderClient.h - Issue 517043003: Move Frame to the Oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/loader/FrameLoaderClient.h

Issue 517043003: Move Frame to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Back out non-Oilpan experiment + tidy up by adding frame() ref accessors Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/loader/FrameLoaderClient.h

diff --git a/Source/core/loader/FrameLoaderClient.h b/Source/core/loader/FrameLoaderClient.h

index 4b9e96c96024d52ccf2cffc9af30cab9fca3713e..3e164d22f0642cde14e27eeb24f521b20da0ff06 100644

--- a/Source/core/loader/FrameLoaderClient.h

+++ b/Source/core/loader/FrameLoaderClient.h

@@ -34,6 +34,7 @@

#include "core/frame/FrameClient.h"

#include "core/loader/FrameLoaderTypes.h"

#include "core/loader/NavigationPolicy.h"

+#include "platform/heap/Handle.h"

#include "platform/network/ResourceLoadPriority.h"

#include "platform/weborigin/Referrer.h"

#include "wtf/Forward.h"

@@ -142,7 +143,7 @@ namespace blink {

virtual void transitionToCommittedForNewPage() = 0;

- virtual PassRefPtr<LocalFrame> createFrame(const KURL&, const AtomicString& name, const Referrer&, HTMLFrameOwnerElement*) = 0;

+ virtual PassRefPtrWillBeRawPtr<LocalFrame> createFrame(const KURL&, const AtomicString& name, const Referrer&, HTMLFrameOwnerElement*) = 0;

// Whether or not plugin creation should fail if the HTMLPlugInElement isn't in the DOM after plugin initialization.

enum DetachedPluginPolicy {

FailOnDetachedPlugin,