Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1372)

Unified Diff: Source/core/loader/FrameFetchContext.h

Issue 517043003: Move Frame to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Back out non-Oilpan experiment + tidy up by adding frame() ref accessors Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/loader/FrameFetchContext.h
diff --git a/Source/core/loader/FrameFetchContext.h b/Source/core/loader/FrameFetchContext.h
index 7d700d9781e71473b75521d8dd81010f717d7ef6..51267419b11e67a6199e45a1c3b7799517f5e0e8 100644
--- a/Source/core/loader/FrameFetchContext.h
+++ b/Source/core/loader/FrameFetchContext.h
@@ -32,6 +32,7 @@
#define FrameFetchContext_h
#include "core/fetch/FetchContext.h"
+#include "platform/heap/Handle.h"
#include "platform/network/ResourceRequest.h"
#include "wtf/PassOwnPtr.h"
@@ -47,7 +48,10 @@ class ResourceRequest;
class FrameFetchContext FINAL : public FetchContext {
public:
- static PassOwnPtr<FrameFetchContext> create(LocalFrame* frame) { return adoptPtr(new FrameFetchContext(frame)); }
+ static PassOwnPtrWillBeRawPtr<FrameFetchContext> create(LocalFrame* frame)
+ {
+ return adoptPtrWillBeNoop(new FrameFetchContext(frame));
+ }
virtual void reportLocalLoadFailed(const KURL&) OVERRIDE;
virtual void addAdditionalRequestHeaders(Document*, ResourceRequest&, FetchResourceType) OVERRIDE;
@@ -63,11 +67,13 @@ public:
virtual void dispatchDidFail(DocumentLoader*, unsigned long identifier, const ResourceError&) OVERRIDE;
virtual void sendRemainingDelegateMessages(DocumentLoader*, unsigned long identifier, const ResourceResponse&, int dataLength) OVERRIDE;
+ virtual void trace(Visitor*) OVERRIDE;
+
private:
explicit FrameFetchContext(LocalFrame*);
inline DocumentLoader* ensureLoader(DocumentLoader*);
- LocalFrame* m_frame;
+ RawPtrWillBeMember<LocalFrame> m_frame;
};
}

Powered by Google App Engine
This is Rietveld 408576698