Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(984)

Unified Diff: Source/core/loader/DocumentWriter.cpp

Issue 517043003: Move Frame to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Back out non-Oilpan experiment + tidy up by adding frame() ref accessors Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/loader/DocumentWriter.cpp
diff --git a/Source/core/loader/DocumentWriter.cpp b/Source/core/loader/DocumentWriter.cpp
index 6aa5acbd902aa8b41f36508709a207b0b7843341..ef7b636f7fff42b4f2ed4d6ff1d477208724b9b1 100644
--- a/Source/core/loader/DocumentWriter.cpp
+++ b/Source/core/loader/DocumentWriter.cpp
@@ -31,13 +31,13 @@
#include "core/dom/Document.h"
#include "core/dom/ScriptableDocumentParser.h"
-#include "core/html/parser/TextResourceDecoder.h"
-#include "core/loader/FrameLoader.h"
-#include "core/loader/FrameLoaderStateMachine.h"
-#include "core/frame/LocalDOMWindow.h"
#include "core/frame/FrameView.h"
+#include "core/frame/LocalDOMWindow.h"
#include "core/frame/LocalFrame.h"
#include "core/frame/Settings.h"
+#include "core/html/parser/TextResourceDecoder.h"
+#include "core/loader/FrameLoader.h"
+#include "core/loader/FrameLoaderStateMachine.h"
#include "platform/weborigin/KURL.h"
#include "platform/weborigin/SecurityOrigin.h"
#include "wtf/PassOwnPtr.h"
@@ -106,7 +106,7 @@ void DocumentWriter::end()
// http://bugs.webkit.org/show_bug.cgi?id=10854
// The frame's last ref may be removed and it can be deleted by checkCompleted(),
// so we'll add a protective refcount
- RefPtr<LocalFrame> protector(m_document->frame());
+ RefPtrWillBeRawPtr<LocalFrame> protect(m_document->frame());
if (!m_parser)
return;

Powered by Google App Engine
This is Rietveld 408576698