Source/core/html/HTMLTextFormControlElementTest.cpp - Issue 517043003: Move Frame to the Oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLTextFormControlElementTest.cpp

Issue 517043003: Move Frame to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Back out non-Oilpan experiment + tidy up by adding frame() ref accessors Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/html/HTMLFrameOwnerElement.cpp ('K') | « Source/core/html/HTMLFrameOwnerElement.cpp ('k') | Source/core/html/parser/XSSAuditorDelegate.cpp » ('j') | Source/core/loader/FrameLoader.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/HTMLTextFormControlElementTest.cpp

diff --git a/Source/core/html/HTMLTextFormControlElementTest.cpp b/Source/core/html/HTMLTextFormControlElementTest.cpp

index 26a7ad2199f16a0e73edad78288942ee1d825152..96dc6f8dfcf3b57d2b6b79fe21e3c109a09e1aef 100644

--- a/Source/core/html/HTMLTextFormControlElementTest.cpp

+++ b/Source/core/html/HTMLTextFormControlElementTest.cpp

@@ -218,7 +218,7 @@ TEST_F(HTMLTextFormControlElementTest, SpellCheckDoesNotCauseUpdateLayout)

document().frame()->selection().setSelection(newSelection, FrameSelection::CloseTyping | FrameSelection::ClearTypingStyle | FrameSelection::DoNotUpdateAppearance);

ASSERT_EQ(3, input->selectionStart());

- OwnPtr<SpellChecker> spellChecker(SpellChecker::create(page().frame()));

+ OwnPtrWillBePersistent<SpellChecker> spellChecker(SpellChecker::create(page().frame()));

forceLayoutFlag();

int startCount = layoutCount();

spellChecker->respondToChangedSelection(oldSelection, FrameSelection::CloseTyping | FrameSelection::ClearTypingStyle);