Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1071)

Unified Diff: Source/core/html/HTMLFrameOwnerElement.h

Issue 517043003: Move Frame to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Back out non-Oilpan experiment + tidy up by adding frame() ref accessors Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/HTMLFrameOwnerElement.h
diff --git a/Source/core/html/HTMLFrameOwnerElement.h b/Source/core/html/HTMLFrameOwnerElement.h
index 9655c0f4ee9d90d5bddac79f1a71c896f16bcf2a..94ed55576faa3e7f6ed3b260782a8ee81f73bc15 100644
--- a/Source/core/html/HTMLFrameOwnerElement.h
+++ b/Source/core/html/HTMLFrameOwnerElement.h
@@ -37,6 +37,7 @@ class RenderPart;
class Widget;
class HTMLFrameOwnerElement : public HTMLElement, public FrameOwner {
+ WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(HTMLFrameOwnerElement);
public:
virtual ~HTMLFrameOwnerElement();
@@ -76,6 +77,8 @@ public:
void performDeferredWidgetTreeOperations();
};
+ virtual void trace(Visitor*) OVERRIDE;
+
protected:
HTMLFrameOwnerElement(const QualifiedName& tagName, Document&);
void setSandboxFlags(SandboxFlags);
@@ -91,7 +94,7 @@ private:
virtual SandboxFlags sandboxFlags() const OVERRIDE { return m_sandboxFlags; }
virtual void dispatchLoad() OVERRIDE;
- Frame* m_contentFrame;
+ RawPtrWillBeMember<Frame> m_contentFrame;
RefPtr<Widget> m_widget;
SandboxFlags m_sandboxFlags;
};

Powered by Google App Engine
This is Rietveld 408576698