Source/core/editing/CompositeEditCommand.cpp - Issue 517043003: Move Frame to the Oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/CompositeEditCommand.cpp

Issue 517043003: Move Frame to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Back out non-Oilpan experiment + tidy up by adding frame() ref accessors Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/editing/CompositeEditCommand.cpp

diff --git a/Source/core/editing/CompositeEditCommand.cpp b/Source/core/editing/CompositeEditCommand.cpp

index 08794dee7ec89d4cd8f7a9084e24fb8901516b8b..7fb51271251d81cfac1a7c70c985bc24f203f023 100644

--- a/Source/core/editing/CompositeEditCommand.cpp

+++ b/Source/core/editing/CompositeEditCommand.cpp

@@ -103,7 +103,7 @@ bool EditCommandComposition::belongsTo(const LocalFrame& frame) const

void EditCommandComposition::unapply()

{

ASSERT(m_document);

- RefPtr<LocalFrame> frame = m_document->frame();

+ RefPtrWillBeRawPtr<LocalFrame> frame = m_document->frame();

ASSERT(frame);

// Changes to the document may have been made since the last editing operation that require a layout, as in <rdar://problem/5658603>.

@@ -123,7 +123,7 @@ void EditCommandComposition::unapply()

void EditCommandComposition::reapply()

{

ASSERT(m_document);

- RefPtr<LocalFrame> frame = m_document->frame();

+ RefPtrWillBeRawPtr<LocalFrame> frame = m_document->frame();

ASSERT(frame);

// Changes to the document may have been made since the last editing operation that require a layout, as in <rdar://problem/5658603>.