Source/bindings/core/v8/custom/V8HTMLDocumentCustom.cpp - Issue 517043003: Move Frame to the Oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/custom/V8HTMLDocumentCustom.cpp

Issue 517043003: Move Frame to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Back out non-Oilpan experiment + tidy up by adding frame() ref accessors Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/core/v8/custom/V8HTMLDocumentCustom.cpp

diff --git a/Source/bindings/core/v8/custom/V8HTMLDocumentCustom.cpp b/Source/bindings/core/v8/custom/V8HTMLDocumentCustom.cpp

index a31741031529568d58588474bfe91f6095abc4b1..88531a3808abe061ed1e22626a997962ac19ebdc 100644

--- a/Source/bindings/core/v8/custom/V8HTMLDocumentCustom.cpp

+++ b/Source/bindings/core/v8/custom/V8HTMLDocumentCustom.cpp

@@ -56,7 +56,7 @@ void V8HTMLDocument::openMethodCustom(const v8::FunctionCallbackInfo<v8::Value>&

HTMLDocument* htmlDocument = V8HTMLDocument::toImpl(info.Holder());

if (info.Length() > 2) {

- if (RefPtr<LocalFrame> frame = htmlDocument->frame()) {

+ if (RefPtrWillBeRawPtr<LocalFrame> frame = htmlDocument->frame()) {

// Fetch the global object for the frame.

v8::Local<v8::Context> context = toV8Context(frame.get(), DOMWrapperWorld::current(info.GetIsolate()));

// Bail out if we cannot get the context.