LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced.html - Issue 517043003: Move Frame to the Oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced.html

Issue 517043003: Move Frame to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Back out non-Oilpan experiment + tidy up by adding frame() ref accessors Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/dom/Window/orphaned-frame-access-expected.txt ('k') | LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced.html » ('j') | Source/core/editing/SpellChecker.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced.html

diff --git a/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced.html b/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced.html

index 96b703393fdb1afa6fd4a705d6d4a27e42ddf7c8..ce546cefa569caa851a2758a5ba6749ce24a838c 100644

--- a/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced.html

+++ b/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced.html

@@ -29,16 +29,11 @@ function runTest()

// Have expected results assume that the frame has been closed (=> window.closed = true.)

collectProperties(true);

frame.parentNode.removeChild(frame);

- window.setTimeout(verifyResults, 0);

-function verifyResults()

- if (window.gc)

- gc();

- for (var i = 0; i < propertiesToVerify.length; ++i)

- shouldBe(propertiesToVerify[i].property, propertiesToVerify[i].expected);

- finishJSTest();

+ asyncGC(function () {

+ for (var i = 0; i < propertiesToVerify.length; ++i)

+ shouldBe(propertiesToVerify[i].property, propertiesToVerify[i].expected);

+ finishJSTest();

+ });

}

</script>

</head>