LayoutTests/fast/dom/Window/orphaned-frame-access.html - Issue 517043003: Move Frame to the Oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/dom/Window/orphaned-frame-access.html

Issue 517043003: Move Frame to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Back out non-Oilpan experiment + tidy up by adding frame() ref accessors Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: LayoutTests/fast/dom/Window/orphaned-frame-access.html

diff --git a/LayoutTests/fast/dom/Window/orphaned-frame-access.html b/LayoutTests/fast/dom/Window/orphaned-frame-access.html

index a61e6834125ec7257c5185e0dfcca1da1e950ae0..1a0ec1bdbf6cde672c173c5520e835b0fbcfc853 100644

--- a/LayoutTests/fast/dom/Window/orphaned-frame-access.html

+++ b/LayoutTests/fast/dom/Window/orphaned-frame-access.html

@@ -1,9 +1,12 @@

-<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Strict//EN">

+<!DOCTYPE HTML>

<html>

<head>

-<meta HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=UTF-8">

<title>Null frame access tests</title>

+<script src="../../../resources/js-test.js"></script>

+description("This tests access to a window with a null frame. You should see \"PASS\" for each of the three tests below.");

+window.jsTestIsAsync = true;

window.onload = function() {

if (window.testRunner) {

testRunner.dumpAsText();

@@ -16,18 +19,16 @@ window.onload = function() {

tag.parentNode.removeChild(tag);

// schedule to run after the frame is null

- setTimeout(function() {

- document.body.appendChild(document.createTextNode(win.test || 'property: PASS ... '));

- document.body.appendChild(document.createTextNode(win[20] || 'array: PASS ... '));

- document.body.appendChild(document.createTextNode(win.Comment || 'missing property: PASS.'));

- if (window.testRunner)

- testRunner.notifyDone();

- }, 0);

+ asyncGC(function() {

+ debug("missing property: " + (win.test || 'PASS'))

+ debug("missing array index: " + (win[20] || 'PASS'));

+ debug("missing interface object: " + (win.Comment || 'PASS'));

+ finishJSTest();

+ });

};

</script>

</head>

<body>

-This tests access to a window with a null frame. You should see "PASS" for each of the three tests below.<br /><br />

</body>

</html>

« no previous file with comments | « no previous file | LayoutTests/fast/dom/Window/orphaned-frame-access-expected.txt » ('j') | Source/core/editing/SpellChecker.h » ('J')