Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1037)

Unified Diff: Source/core/loader/ProgressTracker.h

Issue 517043003: Move Frame to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Experiment: also clear FrameView and FrameLoader during owner disconnect for non-Oilpan Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/loader/NavigationScheduler.cpp ('k') | Source/core/page/Chrome.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/loader/ProgressTracker.h
diff --git a/Source/core/loader/ProgressTracker.h b/Source/core/loader/ProgressTracker.h
index 5e7188fa8885bec9cfbf4e0338c398988a41aa73..ead18ffa18172d49208880b5a659fb023509693f 100644
--- a/Source/core/loader/ProgressTracker.h
+++ b/Source/core/loader/ProgressTracker.h
@@ -66,6 +66,14 @@ private:
void reset();
+ // This bare frame pointer is safe; it refers to the
+ // owning frame (via FrameLoader.)
+ //
+ // ProgressTracker is finalized by FrameLoader (which in turn is
+ // finalized by LocalFrame.) Its lifetime thus guarantees that
+ // m_frame cannot be used to access a dead LocalFrame.
+ //
+ // FIXME: Oilpan: tidy up and move ProgressTracker to the heap.
LocalFrame* m_frame;
bool m_inProgress;
long long m_totalPageAndResourceBytesToLoad;
« no previous file with comments | « Source/core/loader/NavigationScheduler.cpp ('k') | Source/core/page/Chrome.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698