Source/core/html/parser/XSSAuditorDelegate.cpp - Issue 517043003: Move Frame to the Oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/parser/XSSAuditorDelegate.cpp

Issue 517043003: Move Frame to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Experiment: also clear FrameView and FrameLoader during owner disconnect for non-Oilpan Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/parser/XSSAuditorDelegate.cpp

diff --git a/Source/core/html/parser/XSSAuditorDelegate.cpp b/Source/core/html/parser/XSSAuditorDelegate.cpp

index 51f0825f52b89b57da5d37814a62de594734fcb5..b13435db3fa1ec9b0dd144df6341095628655c93 100644

--- a/Source/core/html/parser/XSSAuditorDelegate.cpp

+++ b/Source/core/html/parser/XSSAuditorDelegate.cpp

@@ -107,7 +107,7 @@ void XSSAuditorDelegate::didBlockScript(const XSSInfo& xssInfo)

m_document->addConsoleMessage(ConsoleMessage::create(JSMessageSource, ErrorMessageLevel, xssInfo.buildConsoleError()));

// stopAllLoaders can detach the LocalFrame, so protect it.

- RefPtr<LocalFrame> protect(m_document->frame());

+ RefPtrWillBeRawPtr<LocalFrame> protect(m_document->frame());

FrameLoader& frameLoader = m_document->frame()->loader();

if (xssInfo.m_didBlockEntirePage)

frameLoader.stopAllLoaders();