Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(636)

Unified Diff: Source/core/frame/RemoteFrameView.h

Issue 517043003: Move Frame to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Experiment: also clear FrameView and FrameLoader during owner disconnect for non-Oilpan Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/frame/RemoteFrame.cpp ('k') | Source/core/frame/SmartClip.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/frame/RemoteFrameView.h
diff --git a/Source/core/frame/RemoteFrameView.h b/Source/core/frame/RemoteFrameView.h
index 614e3a5e8015cc038f8468645442366eb3eff3e5..b6b29050b887361a31f2e7ed305637eb037d28b9 100644
--- a/Source/core/frame/RemoteFrameView.h
+++ b/Source/core/frame/RemoteFrameView.h
@@ -7,6 +7,7 @@
#include "platform/Widget.h"
#include "platform/geometry/IntRect.h"
+#include "platform/heap/Handle.h"
namespace blink {
@@ -32,7 +33,10 @@ public:
private:
explicit RemoteFrameView(RemoteFrame*);
- RefPtr<RemoteFrame> m_remoteFrame;
+ // The RefPtrWillBePersistent-cycle between RemoteFrame and its RemoteFrameView
+ // is broken in the same manner as FrameView::m_frame and LocalFrame::m_view is.
+ // See the FrameView::m_frame comment.
+ RefPtrWillBePersistent<RemoteFrame> m_remoteFrame;
};
DEFINE_TYPE_CASTS(RemoteFrameView, Widget, widget, widget->isRemoteFrameView(), widget.isRemoteFrameView());
« no previous file with comments | « Source/core/frame/RemoteFrame.cpp ('k') | Source/core/frame/SmartClip.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698