Source/web/tests/WebViewTest.cpp - Issue 517043003: Move Frame to the Oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/tests/WebViewTest.cpp

Issue 517043003: Move Frame to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add LocalFrame::detachView() + more Oilpan frame finalization comments Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/tests/WebViewTest.cpp

diff --git a/Source/web/tests/WebViewTest.cpp b/Source/web/tests/WebViewTest.cpp

index 2989695d443e2c8c19ea5f77c40e0faa56cfcf9b..a83c13f2da394372b339bcd6695c405dc814c7ff 100644

--- a/Source/web/tests/WebViewTest.cpp

+++ b/Source/web/tests/WebViewTest.cpp

@@ -285,8 +285,10 @@ TEST_F(WebViewTest, SetBaseBackgroundColorBeforeMainFrame)

// webView does not have a frame yet, but we should still be able to set the background color.

webView->setBaseBackgroundColor(kBlue);

EXPECT_EQ(kBlue, webView->backgroundColor());

- webView->setMainFrame(WebLocalFrameImpl::create(0));

+ WebLocalFrameImpl* frame = WebLocalFrameImpl::create(0);

+ webView->setMainFrame(frame);

webView->close();

+ frame->close();

}

TEST_F(WebViewTest, SetBaseBackgroundColorAndBlendWithExistingContent)