Source/web/WebPagePopupImpl.cpp - Issue 517043003: Move Frame to the Oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebPagePopupImpl.cpp

Issue 517043003: Move Frame to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add LocalFrame::detachView() + more Oilpan frame finalization comments Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/WebPagePopupImpl.cpp

diff --git a/Source/web/WebPagePopupImpl.cpp b/Source/web/WebPagePopupImpl.cpp

index 9f5d47079ad778fe0252f777f798f975a007625a..06ab2430d10825152d05773c3ffded8763f66577 100644

--- a/Source/web/WebPagePopupImpl.cpp

+++ b/Source/web/WebPagePopupImpl.cpp

@@ -233,8 +233,8 @@ bool WebPagePopupImpl::initializePage()

m_page->settings().setAccessibilityEnabled(m_webView->page()->settings().accessibilityEnabled());

provideContextFeaturesTo(*m_page, adoptPtr(new PagePopupFeaturesClient()));

- static FrameLoaderClient* emptyFrameLoaderClient = new EmptyFrameLoaderClient();

- RefPtr<LocalFrame> frame = LocalFrame::create(emptyFrameLoaderClient, &m_page->frameHost(), 0);

+ static FrameLoaderClient* emptyFrameLoaderClient = new EmptyFrameLoaderClient();

+ RefPtrWillBeRawPtr<LocalFrame> frame = LocalFrame::create(emptyFrameLoaderClient, &m_page->frameHost(), 0);

frame->setPagePopupOwner(m_popupClient->ownerElement());

frame->setView(FrameView::create(frame.get()));

frame->init();