Source/core/svg/graphics/SVGImage.cpp - Issue 517043003: Move Frame to the Oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/graphics/SVGImage.cpp

Issue 517043003: Move Frame to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add LocalFrame::detachView() + more Oilpan frame finalization comments Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/svg/graphics/SVGImage.cpp

diff --git a/Source/core/svg/graphics/SVGImage.cpp b/Source/core/svg/graphics/SVGImage.cpp

index ab54b36ae8eff618fe1d5dd794007967ddf6a5a4..f93942a9657f3d65cc1d4458c00ff7c56ca790cb 100644

--- a/Source/core/svg/graphics/SVGImage.cpp

+++ b/Source/core/svg/graphics/SVGImage.cpp

@@ -408,7 +408,7 @@ bool SVGImage::dataChanged(bool allDataReceived)

page->settings().setAcceleratedCompositingEnabled(false);

}

- RefPtr<LocalFrame> frame;

+ RefPtrWillBeRawPtr<LocalFrame> frame = nullptr;

{

TRACE_EVENT0("blink", "SVGImage::dataChanged::createFrame");

frame = LocalFrame::create(dummyFrameLoaderClient, &page->frameHost(), 0);