Source/core/plugins/DOMMimeType.h - Issue 517043003: Move Frame to the Oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/plugins/DOMMimeType.h

Issue 517043003: Move Frame to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add LocalFrame::detachView() + more Oilpan frame finalization comments Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/plugins/DOMMimeType.h

diff --git a/Source/core/plugins/DOMMimeType.h b/Source/core/plugins/DOMMimeType.h

index 78518a279a8c482b0410c909223a141d9bfaa9f5..d8b2a7ba3db8c611eea4cf2d2edd7292eb578566 100644

--- a/Source/core/plugins/DOMMimeType.h

+++ b/Source/core/plugins/DOMMimeType.h

@@ -35,6 +35,7 @@ class DOMPlugin;

class LocalFrame;

class DOMMimeType FINAL : public RefCountedWillBeGarbageCollectedFinalized<DOMMimeType>, public ScriptWrappable, public FrameDestructionObserver {

+ WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(DOMMimeType);

DEFINE_WRAPPERTYPEINFO();

public:

static PassRefPtrWillBeRawPtr<DOMMimeType> create(PassRefPtr<PluginData> pluginData, LocalFrame* frame, unsigned index)

@@ -48,7 +49,7 @@ public:

const String& description() const;

PassRefPtrWillBeRawPtr<DOMPlugin> enabledPlugin() const;

- void trace(Visitor*) { }

+ virtual void trace(Visitor*) OVERRIDE;

private:

const MimeClassInfo& mimeClassInfo() const { return m_pluginData->mimes()[m_index]; }