Source/core/page/PageAnimator.cpp - Issue 517043003: Move Frame to the Oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/PageAnimator.cpp

Issue 517043003: Move Frame to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add LocalFrame::detachView() + more Oilpan frame finalization comments Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/page/PageAnimator.cpp

diff --git a/Source/core/page/PageAnimator.cpp b/Source/core/page/PageAnimator.cpp

index f4fd44e6b752a46f9bf4bffab7cf4c808791c3d2..8d9eefabb6f24df937ea357cc88269755e02eb6e 100644

--- a/Source/core/page/PageAnimator.cpp

+++ b/Source/core/page/PageAnimator.cpp

@@ -66,7 +66,6 @@ void PageAnimator::scheduleVisualUpdate()

void PageAnimator::updateLayoutAndStyleForPainting(LocalFrame* rootFrame)

{

RefPtr<FrameView> view = rootFrame->view();

TemporaryChange<bool> servicing(m_updatingLayoutAndStyleForPainting, true);

// In order for our child HWNDs (NativeWindowWidgets) to update properly,