Source/core/page/Page.h - Issue 517043003: Move Frame to the Oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/Page.h

Issue 517043003: Move Frame to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add LocalFrame::detachView() + more Oilpan frame finalization comments Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/page/Page.h

diff --git a/Source/core/page/Page.h b/Source/core/page/Page.h

index e90ae63be7681ce90f8ef858b913b16de1acf503..9f3020f699c100b117799d39398b0dc7813bddff 100644

--- a/Source/core/page/Page.h

+++ b/Source/core/page/Page.h

@@ -254,7 +254,7 @@ private:

const OwnPtr<Chrome> m_chrome;

const OwnPtrWillBeMember<DragCaretController> m_dragCaretController;

const OwnPtrWillBeMember<DragController> m_dragController;

- const OwnPtr<FocusController> m_focusController;

+ const OwnPtrWillBeMember<FocusController> m_focusController;

const OwnPtrWillBeMember<ContextMenuController> m_contextMenuController;

const OwnPtrWillBeMember<InspectorController> m_inspectorController;

const OwnPtrWillBeMember<PointerLockController> m_pointerLockController;