Source/core/plugins/DOMPlugin.h - Issue 517043003: Move Frame to the Oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/plugins/DOMPlugin.h

Issue 517043003: Move Frame to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase past r181764 Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/plugins/DOMPlugin.h

diff --git a/Source/core/plugins/DOMPlugin.h b/Source/core/plugins/DOMPlugin.h

index d9b1eb76cfe86101614f361248e149a99b194e0b..fa65605547086609d6881bf7d7802cbd133d53ab 100644

--- a/Source/core/plugins/DOMPlugin.h

+++ b/Source/core/plugins/DOMPlugin.h

@@ -34,6 +34,7 @@ class Plugin;

class PluginData;

class DOMPlugin FINAL : public RefCountedWillBeGarbageCollectedFinalized<DOMPlugin>, public ScriptWrappable, public FrameDestructionObserver {

+ WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(DOMPlugin);

DEFINE_WRAPPERTYPEINFO();

public:

static PassRefPtrWillBeRawPtr<DOMPlugin> create(PluginData* pluginData, LocalFrame* frame, unsigned index)

@@ -52,7 +53,7 @@ public:

bool canGetItemsForName(const AtomicString& propertyName);

PassRefPtrWillBeRawPtr<DOMMimeType> namedItem(const AtomicString& propertyName);

- void trace(Visitor*) { }

+ virtual void trace(Visitor*) OVERRIDE;

haraken 2014/09/11 14:47:25 Nit: We won't need this.

private:

const PluginInfo& pluginInfo() const { return m_pluginData->plugins()[m_index]; }