Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(749)

Unified Diff: Source/core/frame/FrameView.h

Issue 517043003: Move Frame to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase past r181764 Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/frame/FrameView.h
diff --git a/Source/core/frame/FrameView.h b/Source/core/frame/FrameView.h
index dffc6f79fa8f9ec0e1199240eb2218c26f5f2bbd..9db32f432b53ac9eb7053272ae50b25e05dd5082 100644
--- a/Source/core/frame/FrameView.h
+++ b/Source/core/frame/FrameView.h
@@ -57,6 +57,7 @@ class RenderWidget;
typedef unsigned long long DOMTimeStamp;
+// FIXME: Oilpan: move FrameView (or ScrollView) to the heap.
class FrameView FINAL : public ScrollView {
public:
friend class RenderView;
@@ -414,7 +415,9 @@ private:
// FIXME: These are just "children" of the FrameView and should be RefPtr<Widget> instead.
WillBePersistentHeapHashSet<RefPtrWillBeMember<RenderWidget> > m_widgets;
- RefPtr<LocalFrame> m_frame;
+ // FIXME: Oilpan: the persistent back reference looks too strong, but it
+ // 'emulates' the RefPtr-cycle that is kept between the two objects non-Oilpan.
haraken 2014/09/11 14:47:25 Would you add a comment about how the ref-cycle ge
sof 2014/09/12 14:47:40 Done (and thanks for the original explanation!)
+ RefPtrWillBePersistent<LocalFrame> m_frame;
bool m_doFullPaintInvalidation;

Powered by Google App Engine
This is Rietveld 408576698