Source/core/frame/BarProp.h - Issue 517043003: Move Frame to the Oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/BarProp.h

Issue 517043003: Move Frame to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Update OilpanExpectations Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/frame/BarProp.h

diff --git a/Source/core/frame/BarProp.h b/Source/core/frame/BarProp.h

index a6ea89e2115faa3ea376f9252a6c0a0abe94bd36..193fbaa82bedf5a70e3b78bb2603863e8d9b3da6 100644

--- a/Source/core/frame/BarProp.h

+++ b/Source/core/frame/BarProp.h

@@ -41,6 +41,7 @@ class LocalFrame;

class BarProp FINAL : public RefCountedWillBeGarbageCollectedFinalized<BarProp>, public ScriptWrappable, public DOMWindowProperty {

DEFINE_WRAPPERTYPEINFO();

+ WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(BarProp);

public:

enum Type { Locationbar, Menubar, Personalbar, Scrollbars, Statusbar, Toolbar };

@@ -51,7 +52,7 @@ public:

bool visible() const;

- void trace(Visitor*) { }

+ virtual void trace(Visitor*) OVERRIDE;

private:

BarProp(LocalFrame*, Type);