Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Unified Diff: Source/web/DragClientImpl.cpp

Issue 517043003: Move Frame to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase past r181245 conflict Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/DragClientImpl.cpp
diff --git a/Source/web/DragClientImpl.cpp b/Source/web/DragClientImpl.cpp
index 23876d1858083225d81161cfe7be0ca93542a357..cc4ff7a69c6e0d235b93ada8fe79ac0f9d218a8f 100644
--- a/Source/web/DragClientImpl.cpp
+++ b/Source/web/DragClientImpl.cpp
@@ -33,6 +33,7 @@
#include "core/clipboard/DataObject.h"
#include "core/clipboard/DataTransfer.h"
+#include "core/frame/FrameProtector.h"
#include "core/frame/LocalFrame.h"
#include "platform/DragImage.h"
#include "platform/geometry/IntSize.h"
@@ -61,7 +62,7 @@ DragDestinationAction DragClientImpl::actionMaskForDrag(DragData*)
void DragClientImpl::startDrag(DragImage* dragImage, const IntPoint& dragImageOrigin, const IntPoint& eventPos, DataTransfer* dataTransfer, LocalFrame* frame, bool isLinkDrag)
{
// Add a ref to the frame just in case a load occurs mid-drag.
- RefPtr<LocalFrame> frameProtector = frame;
+ FrameProtector frameProtector(frame);
WebDragData dragData(dataTransfer->dataObject());
WebDragOperationsMask dragOperationMask = static_cast<WebDragOperationsMask>(dataTransfer->sourceOperation());

Powered by Google App Engine
This is Rietveld 408576698