Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1284)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: Source/core/testing/DummyPageHolder.cpp

Issue 517043003: Move Frame to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase past r181245 conflict Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« Source/core/page/ScopedPageLoadDeferrer.cpp ('K') | « Source/core/testing/DummyPageHolder.h ('k') | Source/modules/geolocation/GeolocationController.h » ('j') | Source/web/PopupContainer.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/testing/DummyPageHolder.cpp
diff --git a/Source/core/testing/DummyPageHolder.cpp b/Source/core/testing/DummyPageHolder.cpp
index 78401b21b6f2b9c19e343c52ef350310d66d0253..56a4ee526afc3f29da50d9086c6cbd263edbdb6b 100644
--- a/Source/core/testing/DummyPageHolder.cpp
+++ b/Source/core/testing/DummyPageHolder.cpp
@@ -73,7 +73,9 @@ DummyPageHolder::~DummyPageHolder()
{
m_page->willBeDestroyed();
m_page.clear();
-#if !ENABLE(OILPAN)
+#if ENABLE(OILPAN)
+ m_frame->willBeDestroyed();
+#else
ASSERT(m_frame->hasOneRef());
#endif
m_frame.clear();
« Source/core/page/ScopedPageLoadDeferrer.cpp ('K') | « Source/core/testing/DummyPageHolder.h ('k') | Source/modules/geolocation/GeolocationController.h » ('j') | Source/web/PopupContainer.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698