| Index: Source/core/page/FocusController.cpp
|
| diff --git a/Source/core/page/FocusController.cpp b/Source/core/page/FocusController.cpp
|
| index 149ff8a87bca01cdc267d43e738c6569f5615562..d1bddc956ff31f54e39fda798afbe2ac4ed03838 100644
|
| --- a/Source/core/page/FocusController.cpp
|
| +++ b/Source/core/page/FocusController.cpp
|
| @@ -40,8 +40,9 @@
|
| #include "core/editing/FrameSelection.h"
|
| #include "core/editing/htmlediting.h" // For firstPositionInOrBeforeNode
|
| #include "core/events/Event.h"
|
| -#include "core/frame/LocalDOMWindow.h"
|
| +#include "core/frame/FrameProtector.h"
|
| #include "core/frame/FrameView.h"
|
| +#include "core/frame/LocalDOMWindow.h"
|
| #include "core/frame/LocalFrame.h"
|
| #include "core/html/HTMLAreaElement.h"
|
| #include "core/html/HTMLImageElement.h"
|
| @@ -229,12 +230,12 @@ FocusController::FocusController(Page* page)
|
| {
|
| }
|
|
|
| -PassOwnPtr<FocusController> FocusController::create(Page* page)
|
| +PassOwnPtrWillBeRawPtr<FocusController> FocusController::create(Page* page)
|
| {
|
| - return adoptPtr(new FocusController(page));
|
| + return adoptPtrWillBeNoop(new FocusController(page));
|
| }
|
|
|
| -void FocusController::setFocusedFrame(PassRefPtr<Frame> frame)
|
| +void FocusController::setFocusedFrame(PassRefPtrWillBeRawPtr<Frame> frame)
|
| {
|
| ASSERT(!frame || frame->page() == m_page);
|
| if (m_focusedFrame == frame || m_isChangingFocusedFrame)
|
| @@ -242,8 +243,11 @@ void FocusController::setFocusedFrame(PassRefPtr<Frame> frame)
|
|
|
| m_isChangingFocusedFrame = true;
|
|
|
| - RefPtr<LocalFrame> oldFrame = (m_focusedFrame && m_focusedFrame->isLocalFrame()) ? toLocalFrame(m_focusedFrame.get()) : 0;
|
| - RefPtr<LocalFrame> newFrame = (frame && frame->isLocalFrame()) ? toLocalFrame(frame.get()) : 0;
|
| + LocalFrame* oldFrame = (m_focusedFrame && m_focusedFrame->isLocalFrame()) ? toLocalFrame(m_focusedFrame.get()) : 0;
|
| + FrameProtector protectOld(oldFrame);
|
| +
|
| + LocalFrame* newFrame = (frame && frame->isLocalFrame()) ? toLocalFrame(frame.get()) : 0;
|
| + FrameProtector protectNew(newFrame);
|
|
|
| m_focusedFrame = frame.get();
|
|
|
| @@ -260,16 +264,17 @@ void FocusController::setFocusedFrame(PassRefPtr<Frame> frame)
|
|
|
| m_isChangingFocusedFrame = false;
|
|
|
| - m_page->chrome().client().focusedFrameChanged(newFrame.get());
|
| + m_page->chrome().client().focusedFrameChanged(newFrame);
|
| }
|
|
|
| -void FocusController::focusDocumentView(PassRefPtr<Frame> frame)
|
| +void FocusController::focusDocumentView(PassRefPtrWillBeRawPtr<Frame> frame)
|
| {
|
| ASSERT(!frame || frame->page() == m_page);
|
| if (m_focusedFrame == frame)
|
| return;
|
|
|
| - RefPtr<LocalFrame> focusedFrame = (m_focusedFrame && m_focusedFrame->isLocalFrame()) ? toLocalFrame(m_focusedFrame.get()) : 0;
|
| + LocalFrame* focusedFrame = (m_focusedFrame && m_focusedFrame->isLocalFrame()) ? toLocalFrame(m_focusedFrame.get()) : 0;
|
| + FrameProtector protect(focusedFrame);
|
| if (focusedFrame && focusedFrame->view()) {
|
| RefPtrWillBeRawPtr<Document> document = focusedFrame->document();
|
| Element* focusedElement = document ? document->focusedElement() : 0;
|
| @@ -283,7 +288,8 @@ void FocusController::focusDocumentView(PassRefPtr<Frame> frame)
|
| }
|
| }
|
|
|
| - RefPtr<LocalFrame> newFocusedFrame = (frame && frame->isLocalFrame()) ? toLocalFrame(frame.get()) : 0;
|
| + LocalFrame* newFocusedFrame = (frame && frame->isLocalFrame()) ? toLocalFrame(frame.get()) : 0;
|
| + FrameProtector protectNew(newFocusedFrame);
|
| if (newFocusedFrame && newFocusedFrame->view()) {
|
| RefPtrWillBeRawPtr<Document> document = newFocusedFrame->document();
|
| Element* focusedElement = document ? document->focusedElement() : 0;
|
| @@ -674,9 +680,10 @@ static void clearSelectionIfNeeded(LocalFrame* oldFocusedFrame, LocalFrame* newF
|
| selection.clear();
|
| }
|
|
|
| -bool FocusController::setFocusedElement(Element* element, PassRefPtr<Frame> newFocusedFrame, FocusType type)
|
| +bool FocusController::setFocusedElement(Element* element, PassRefPtrWillBeRawPtr<Frame> newFocusedFrame, FocusType type)
|
| {
|
| - RefPtr<LocalFrame> oldFocusedFrame = toLocalFrame(focusedFrame());
|
| + LocalFrame* oldFocusedFrame = toLocalFrame(focusedFrame());
|
| + FrameProtector protectOld(oldFocusedFrame);
|
| RefPtrWillBeRawPtr<Document> oldDocument = oldFocusedFrame ? oldFocusedFrame->document() : 0;
|
|
|
| Element* oldFocusedElement = oldDocument ? oldDocument->focusedElement() : 0;
|
| @@ -698,7 +705,7 @@ bool FocusController::setFocusedElement(Element* element, PassRefPtr<Frame> newF
|
| if (newDocument && oldDocument == newDocument && newDocument->focusedElement() == element)
|
| return true;
|
|
|
| - clearSelectionIfNeeded(oldFocusedFrame.get(), toLocalFrame(newFocusedFrame.get()), element);
|
| + clearSelectionIfNeeded(oldFocusedFrame, toLocalFrame(newFocusedFrame.get()), element);
|
|
|
| if (oldDocument && oldDocument != newDocument)
|
| oldDocument->setFocusedElement(nullptr);
|
| @@ -925,4 +932,9 @@ bool FocusController::advanceFocusDirectionally(FocusType type)
|
| return consumed;
|
| }
|
|
|
| +void FocusController::trace(Visitor* visitor)
|
| +{
|
| + visitor->trace(m_focusedFrame);
|
| +}
|
| +
|
| } // namespace blink
|
|
|