Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Side by Side Diff: Source/web/SpellCheckerClientImpl.h

Issue 517043003: Move Frame to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Back out non-Oilpan experiment + tidy up by adding frame() ref accessors Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 14 matching lines...) Expand all
25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 */ 29 */
30 30
31 #ifndef SpellCheckerClientImpl_h 31 #ifndef SpellCheckerClientImpl_h
32 #define SpellCheckerClientImpl_h 32 #define SpellCheckerClientImpl_h
33 33
34 #include "core/page/SpellCheckerClient.h" 34 #include "core/page/SpellCheckerClient.h"
35 #include "platform/heap/Handle.h"
35 #include "platform/text/TextCheckerClient.h" 36 #include "platform/text/TextCheckerClient.h"
36 37
37 namespace blink { 38 namespace blink {
38 39
39 class LocalFrame; 40 class LocalFrame;
40 class HTMLInputElement; 41 class HTMLInputElement;
41 class WebViewImpl; 42 class WebViewImpl;
42 43
43 class SpellCheckerClientImpl FINAL : public SpellCheckerClient, public TextCheck erClient { 44 class SpellCheckerClientImpl FINAL : public SpellCheckerClient, public TextCheck erClient {
44 public: 45 public:
45 explicit SpellCheckerClientImpl(WebViewImpl*); 46 explicit SpellCheckerClientImpl(WebViewImpl*);
46 47
47 virtual ~SpellCheckerClientImpl(); 48 virtual ~SpellCheckerClientImpl();
48 49
49 virtual bool isContinuousSpellCheckingEnabled() OVERRIDE; 50 virtual bool isContinuousSpellCheckingEnabled() OVERRIDE;
50 virtual void toggleContinuousSpellChecking() OVERRIDE; 51 virtual void toggleContinuousSpellChecking() OVERRIDE;
51 virtual bool isGrammarCheckingEnabled() OVERRIDE; 52 virtual bool isGrammarCheckingEnabled() OVERRIDE;
52 virtual bool shouldEraseMarkersAfterChangeSelection(TextCheckingType) const OVERRIDE; 53 virtual bool shouldEraseMarkersAfterChangeSelection(TextCheckingType) const OVERRIDE;
53 virtual void checkSpellingOfString(const String&, int* misspellingLocation, int* misspellingLength) OVERRIDE; 54 virtual void checkSpellingOfString(const String&, int* misspellingLocation, int* misspellingLength) OVERRIDE;
54 virtual void checkGrammarOfString(const String&, WTF::Vector<GrammarDetail>& , 55 virtual void checkGrammarOfString(const String&, WTF::Vector<GrammarDetail>& ,
55 int* badGrammarLocation, int* badGrammarLength) OVERRIDE; 56 int* badGrammarLocation, int* badGrammarLength) OVERRIDE;
56 virtual WTF::String getAutoCorrectSuggestionForMisspelledWord(const WTF::Str ing&) OVERRIDE; 57 virtual WTF::String getAutoCorrectSuggestionForMisspelledWord(const WTF::Str ing&) OVERRIDE;
57 virtual void updateSpellingUIWithMisspelledWord(const WTF::String&) OVERRIDE ; 58 virtual void updateSpellingUIWithMisspelledWord(const WTF::String&) OVERRIDE ;
58 virtual void showSpellingUI(bool show) OVERRIDE; 59 virtual void showSpellingUI(bool show) OVERRIDE;
59 virtual bool spellingUIIsShowing() OVERRIDE; 60 virtual bool spellingUIIsShowing() OVERRIDE;
60 virtual void requestCheckingOfString(WTF::PassRefPtr<TextCheckingRequest>) O VERRIDE; 61 virtual void requestCheckingOfString(PassRefPtrWillBeRawPtr<TextCheckingRequ est>) OVERRIDE;
61 62
62 virtual TextCheckerClient& textChecker() OVERRIDE { return *this; } 63 virtual TextCheckerClient& textChecker() OVERRIDE { return *this; }
63 64
64 private: 65 private:
65 // Returns whether or not the focused control needs spell-checking. 66 // Returns whether or not the focused control needs spell-checking.
66 // Currently, this function just retrieves the focused node and determines 67 // Currently, this function just retrieves the focused node and determines
67 // whether or not it is a <textarea> element or an element whose 68 // whether or not it is a <textarea> element or an element whose
68 // contenteditable attribute is true. 69 // contenteditable attribute is true.
69 // FIXME: Bug 740540: This code just implements the default behavior 70 // FIXME: Bug 740540: This code just implements the default behavior
70 // proposed in this issue. We should also retrieve "spellcheck" attributes 71 // proposed in this issue. We should also retrieve "spellcheck" attributes
71 // for text fields and create a flag to over-write the default behavior. 72 // for text fields and create a flag to over-write the default behavior.
72 bool shouldSpellcheckByDefault(); 73 bool shouldSpellcheckByDefault();
73 74
74 WebViewImpl* m_webView; 75 WebViewImpl* m_webView;
75 76
76 // This flag is set to false if spell check for this editor is manually 77 // This flag is set to false if spell check for this editor is manually
77 // turned off. The default setting is SpellCheckAutomatic. 78 // turned off. The default setting is SpellCheckAutomatic.
78 enum { 79 enum {
79 SpellCheckAutomatic, 80 SpellCheckAutomatic,
80 SpellCheckForcedOn, 81 SpellCheckForcedOn,
81 SpellCheckForcedOff 82 SpellCheckForcedOff
82 } m_spellCheckThisFieldStatus; 83 } m_spellCheckThisFieldStatus;
83 }; 84 };
84 85
85 } // namespace blink 86 } // namespace blink
86 87
87 #endif 88 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698