Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Side by Side Diff: Source/web/SpellCheckerClientImpl.cpp

Issue 517043003: Move Frame to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Back out non-Oilpan experiment + tidy up by adding frame() ref accessors Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007 Apple, Inc. All rights reserved. 2 * Copyright (C) 2006, 2007 Apple, Inc. All rights reserved.
3 * Copyright (C) 2012 Google, Inc. All rights reserved. 3 * Copyright (C) 2012 Google, Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 131 matching lines...) Expand 10 before | Expand all | Expand 10 after
142 } 142 }
143 143
144 // Note: the Mac code checks if the pointers are null before writing to them , 144 // Note: the Mac code checks if the pointers are null before writing to them ,
145 // so we do too. 145 // so we do too.
146 if (misspellingLocation) 146 if (misspellingLocation)
147 *misspellingLocation = spellLocation; 147 *misspellingLocation = spellLocation;
148 if (misspellingLength) 148 if (misspellingLength)
149 *misspellingLength = spellLength; 149 *misspellingLength = spellLength;
150 } 150 }
151 151
152 void SpellCheckerClientImpl::requestCheckingOfString(WTF::PassRefPtr<TextCheckin gRequest> request) 152 void SpellCheckerClientImpl::requestCheckingOfString(PassRefPtrWillBeRawPtr<Text CheckingRequest> request)
153 { 153 {
154 if (m_webView->spellCheckClient()) { 154 if (m_webView->spellCheckClient()) {
155 const String& text = request->data().text(); 155 const String& text = request->data().text();
156 const Vector<uint32_t>& markers = request->data().markers(); 156 const Vector<uint32_t>& markers = request->data().markers();
157 const Vector<unsigned>& markerOffsets = request->data().offsets(); 157 const Vector<unsigned>& markerOffsets = request->data().offsets();
158 m_webView->spellCheckClient()->requestCheckingOfText(text, markers, mark erOffsets, new WebTextCheckingCompletionImpl(request)); 158 m_webView->spellCheckClient()->requestCheckingOfText(text, markers, mark erOffsets, new WebTextCheckingCompletionImpl(request));
159 } 159 }
160 } 160 }
161 161
162 String SpellCheckerClientImpl::getAutoCorrectSuggestionForMisspelledWord(const S tring& misspelledWord) 162 String SpellCheckerClientImpl::getAutoCorrectSuggestionForMisspelledWord(const S tring& misspelledWord)
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
224 } 224 }
225 225
226 bool SpellCheckerClientImpl::spellingUIIsShowing() 226 bool SpellCheckerClientImpl::spellingUIIsShowing()
227 { 227 {
228 if (m_webView->spellCheckClient()) 228 if (m_webView->spellCheckClient())
229 return m_webView->spellCheckClient()->isShowingSpellingUI(); 229 return m_webView->spellCheckClient()->isShowingSpellingUI();
230 return false; 230 return false;
231 } 231 }
232 232
233 } // namespace blink 233 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698