Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Side by Side Diff: Source/core/svg/graphics/SVGImage.cpp

Issue 517043003: Move Frame to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Back out non-Oilpan experiment + tidy up by adding frame() ref accessors Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006 Eric Seidel <eric@webkit.org> 2 * Copyright (C) 2006 Eric Seidel <eric@webkit.org>
3 * Copyright (C) 2008, 2009 Apple Inc. All rights reserved. 3 * Copyright (C) 2008, 2009 Apple Inc. All rights reserved.
4 * Copyright (C) Research In Motion Limited 2011. All rights reserved. 4 * Copyright (C) Research In Motion Limited 2011. All rights reserved.
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 390 matching lines...) Expand 10 before | Expand all | Expand 10 after
401 // loaded by a top-level document. 401 // loaded by a top-level document.
402 OwnPtrWillBeRawPtr<Page> page; 402 OwnPtrWillBeRawPtr<Page> page;
403 { 403 {
404 TRACE_EVENT0("blink", "SVGImage::dataChanged::createPage"); 404 TRACE_EVENT0("blink", "SVGImage::dataChanged::createPage");
405 page = adoptPtrWillBeNoop(new Page(pageClients)); 405 page = adoptPtrWillBeNoop(new Page(pageClients));
406 page->settings().setScriptEnabled(false); 406 page->settings().setScriptEnabled(false);
407 page->settings().setPluginsEnabled(false); 407 page->settings().setPluginsEnabled(false);
408 page->settings().setAcceleratedCompositingEnabled(false); 408 page->settings().setAcceleratedCompositingEnabled(false);
409 } 409 }
410 410
411 RefPtr<LocalFrame> frame; 411 RefPtrWillBeRawPtr<LocalFrame> frame = nullptr;
412 { 412 {
413 TRACE_EVENT0("blink", "SVGImage::dataChanged::createFrame"); 413 TRACE_EVENT0("blink", "SVGImage::dataChanged::createFrame");
414 frame = LocalFrame::create(dummyFrameLoaderClient, &page->frameHost( ), 0); 414 frame = LocalFrame::create(dummyFrameLoaderClient, &page->frameHost( ), 0);
415 frame->setView(FrameView::create(frame.get())); 415 frame->setView(FrameView::create(frame.get()));
416 frame->init(); 416 frame->init();
417 } 417 }
418 418
419 FrameLoader& loader = frame->loader(); 419 FrameLoader& loader = frame->loader();
420 loader.forceSandboxFlags(SandboxAll); 420 loader.forceSandboxFlags(SandboxAll);
421 421
(...skipping 12 matching lines...) Expand all
434 434
435 return m_page; 435 return m_page;
436 } 436 }
437 437
438 String SVGImage::filenameExtension() const 438 String SVGImage::filenameExtension() const
439 { 439 {
440 return "svg"; 440 return "svg";
441 } 441 }
442 442
443 } 443 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698