Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Side by Side Diff: Source/core/plugins/DOMPlugin.cpp

Issue 517043003: Move Frame to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Back out non-Oilpan experiment + tidy up by adding frame() ref accessors Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies) 2 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
3 * 3 *
4 * This library is free software; you can redistribute it and/or 4 * This library is free software; you can redistribute it and/or
5 * modify it under the terms of the GNU Lesser General Public 5 * modify it under the terms of the GNU Lesser General Public
6 * License as published by the Free Software Foundation; either 6 * License as published by the Free Software Foundation; either
7 * version 2 of the License, or (at your option) any later version. 7 * version 2 of the License, or (at your option) any later version.
8 * 8 *
9 * This library is distributed in the hope that it will be useful, 9 * This library is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 17 matching lines...) Expand all
28 : FrameDestructionObserver(frame) 28 : FrameDestructionObserver(frame)
29 , m_pluginData(pluginData) 29 , m_pluginData(pluginData)
30 , m_index(index) 30 , m_index(index)
31 { 31 {
32 } 32 }
33 33
34 DOMPlugin::~DOMPlugin() 34 DOMPlugin::~DOMPlugin()
35 { 35 {
36 } 36 }
37 37
38 void DOMPlugin::trace(Visitor* visitor)
39 {
40 FrameDestructionObserver::trace(visitor);
41 }
42
38 String DOMPlugin::name() const 43 String DOMPlugin::name() const
39 { 44 {
40 return pluginInfo().name; 45 return pluginInfo().name;
41 } 46 }
42 47
43 String DOMPlugin::filename() const 48 String DOMPlugin::filename() const
44 { 49 {
45 return pluginInfo().file; 50 return pluginInfo().file;
46 } 51 }
47 52
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
82 PassRefPtrWillBeRawPtr<DOMMimeType> DOMPlugin::namedItem(const AtomicString& pro pertyName) 87 PassRefPtrWillBeRawPtr<DOMMimeType> DOMPlugin::namedItem(const AtomicString& pro pertyName)
83 { 88 {
84 const Vector<MimeClassInfo>& mimes = m_pluginData->mimes(); 89 const Vector<MimeClassInfo>& mimes = m_pluginData->mimes();
85 for (unsigned i = 0; i < mimes.size(); ++i) 90 for (unsigned i = 0; i < mimes.size(); ++i)
86 if (mimes[i].type == propertyName) 91 if (mimes[i].type == propertyName)
87 return DOMMimeType::create(m_pluginData.get(), m_frame, i).get(); 92 return DOMMimeType::create(m_pluginData.get(), m_frame, i).get();
88 return nullptr; 93 return nullptr;
89 } 94 }
90 95
91 } // namespace blink 96 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698