Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Side by Side Diff: Source/core/plugins/DOMMimeType.cpp

Issue 517043003: Move Frame to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Back out non-Oilpan experiment + tidy up by adding frame() ref accessors Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies) 2 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
3 * 3 *
4 * This library is free software; you can redistribute it and/or 4 * This library is free software; you can redistribute it and/or
5 * modify it under the terms of the GNU Lesser General Public 5 * modify it under the terms of the GNU Lesser General Public
6 * License as published by the Free Software Foundation; either 6 * License as published by the Free Software Foundation; either
7 * version 2 of the License, or (at your option) any later version. 7 * version 2 of the License, or (at your option) any later version.
8 * 8 *
9 * This library is distributed in the hope that it will be useful, 9 * This library is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 20 matching lines...) Expand all
31 : FrameDestructionObserver(frame) 31 : FrameDestructionObserver(frame)
32 , m_pluginData(pluginData) 32 , m_pluginData(pluginData)
33 , m_index(index) 33 , m_index(index)
34 { 34 {
35 } 35 }
36 36
37 DOMMimeType::~DOMMimeType() 37 DOMMimeType::~DOMMimeType()
38 { 38 {
39 } 39 }
40 40
41 void DOMMimeType::trace(Visitor* visitor)
42 {
43 FrameDestructionObserver::trace(visitor);
44 }
45
41 const String &DOMMimeType::type() const 46 const String &DOMMimeType::type() const
42 { 47 {
43 return mimeClassInfo().type; 48 return mimeClassInfo().type;
44 } 49 }
45 50
46 String DOMMimeType::suffixes() const 51 String DOMMimeType::suffixes() const
47 { 52 {
48 const Vector<String>& extensions = mimeClassInfo().extensions; 53 const Vector<String>& extensions = mimeClassInfo().extensions;
49 54
50 StringBuilder builder; 55 StringBuilder builder;
(...skipping 15 matching lines...) Expand all
66 // FIXME: allowPlugins is just a client call. We should not need 71 // FIXME: allowPlugins is just a client call. We should not need
67 // to bounce through the loader to get there. 72 // to bounce through the loader to get there.
68 // Something like: m_frame->host()->client()->allowPlugins(). 73 // Something like: m_frame->host()->client()->allowPlugins().
69 if (!m_frame || !m_frame->loader().allowPlugins(NotAboutToInstantiatePlugin) ) 74 if (!m_frame || !m_frame->loader().allowPlugins(NotAboutToInstantiatePlugin) )
70 return nullptr; 75 return nullptr;
71 76
72 return DOMPlugin::create(m_pluginData.get(), m_frame, m_pluginData->mimePlug inIndices()[m_index]); 77 return DOMPlugin::create(m_pluginData.get(), m_frame, m_pluginData->mimePlug inIndices()[m_index]);
73 } 78 }
74 79
75 } // namespace blink 80 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698