Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Side by Side Diff: Source/core/loader/EmptyClients.cpp

Issue 517043003: Move Frame to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Back out non-Oilpan experiment + tidy up by adding frame() ref accessors Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006 Eric Seidel <eric@webkit.org> 2 * Copyright (C) 2006 Eric Seidel <eric@webkit.org>
3 * Copyright (C) 2008, 2009, 2012 Apple Inc. All rights reserved. 3 * Copyright (C) 2008, 2009, 2012 Apple Inc. All rights reserved.
4 * Copyright (C) Research In Motion Limited 2011. All rights reserved. 4 * Copyright (C) Research In Motion Limited 2011. All rights reserved.
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
69 } 69 }
70 70
71 class EmptyPopupMenu : public PopupMenu { 71 class EmptyPopupMenu : public PopupMenu {
72 public: 72 public:
73 virtual void show(const FloatQuad&, const IntSize&, int) OVERRIDE { } 73 virtual void show(const FloatQuad&, const IntSize&, int) OVERRIDE { }
74 virtual void hide() OVERRIDE { } 74 virtual void hide() OVERRIDE { }
75 virtual void updateFromElement() OVERRIDE { } 75 virtual void updateFromElement() OVERRIDE { }
76 virtual void disconnectClient() OVERRIDE { } 76 virtual void disconnectClient() OVERRIDE { }
77 }; 77 };
78 78
79 PassRefPtr<PopupMenu> EmptyChromeClient::createPopupMenu(LocalFrame&, PopupMenuC lient*) const 79 PassRefPtrWillBeRawPtr<PopupMenu> EmptyChromeClient::createPopupMenu(LocalFrame& , PopupMenuClient*) const
80 { 80 {
81 return adoptRef(new EmptyPopupMenu()); 81 return adoptRefWillBeNoop(new EmptyPopupMenu());
82 } 82 }
83 83
84 PassOwnPtr<ColorChooser> EmptyChromeClient::createColorChooser(LocalFrame*, Colo rChooserClient*, const Color&) 84 PassOwnPtr<ColorChooser> EmptyChromeClient::createColorChooser(LocalFrame*, Colo rChooserClient*, const Color&)
85 { 85 {
86 return nullptr; 86 return nullptr;
87 } 87 }
88 88
89 PassRefPtr<DateTimeChooser> EmptyChromeClient::openDateTimeChooser(DateTimeChoos erClient*, const DateTimeChooserParameters&) 89 PassRefPtr<DateTimeChooser> EmptyChromeClient::openDateTimeChooser(DateTimeChoos erClient*, const DateTimeChooserParameters&)
90 { 90 {
91 return PassRefPtr<DateTimeChooser>(); 91 return PassRefPtr<DateTimeChooser>();
(...skipping 23 matching lines...) Expand all
115 115
116 void EmptyFrameLoaderClient::dispatchWillSubmitForm(HTMLFormElement*) 116 void EmptyFrameLoaderClient::dispatchWillSubmitForm(HTMLFormElement*)
117 { 117 {
118 } 118 }
119 119
120 PassRefPtr<DocumentLoader> EmptyFrameLoaderClient::createDocumentLoader(LocalFra me* frame, const ResourceRequest& request, const SubstituteData& substituteData) 120 PassRefPtr<DocumentLoader> EmptyFrameLoaderClient::createDocumentLoader(LocalFra me* frame, const ResourceRequest& request, const SubstituteData& substituteData)
121 { 121 {
122 return DocumentLoader::create(frame, request, substituteData); 122 return DocumentLoader::create(frame, request, substituteData);
123 } 123 }
124 124
125 PassRefPtr<LocalFrame> EmptyFrameLoaderClient::createFrame(const KURL&, const At omicString&, const Referrer&, HTMLFrameOwnerElement*) 125 PassRefPtrWillBeRawPtr<LocalFrame> EmptyFrameLoaderClient::createFrame(const KUR L&, const AtomicString&, const Referrer&, HTMLFrameOwnerElement*)
126 { 126 {
127 return nullptr; 127 return nullptr;
128 } 128 }
129 129
130 PassRefPtr<Widget> EmptyFrameLoaderClient::createPlugin(HTMLPlugInElement*, cons t KURL&, const Vector<String>&, const Vector<String>&, const String&, bool, Deta chedPluginPolicy) 130 PassRefPtr<Widget> EmptyFrameLoaderClient::createPlugin(HTMLPlugInElement*, cons t KURL&, const Vector<String>&, const Vector<String>&, const String&, bool, Deta chedPluginPolicy)
131 { 131 {
132 return nullptr; 132 return nullptr;
133 } 133 }
134 134
135 PassRefPtr<Widget> EmptyFrameLoaderClient::createJavaAppletWidget(HTMLAppletElem ent*, const KURL&, const Vector<String>&, const Vector<String>&) 135 PassRefPtr<Widget> EmptyFrameLoaderClient::createJavaAppletWidget(HTMLAppletElem ent*, const KURL&, const Vector<String>&, const Vector<String>&)
136 { 136 {
137 return nullptr; 137 return nullptr;
138 } 138 }
139 139
140 void EmptyTextCheckerClient::requestCheckingOfString(PassRefPtr<TextCheckingRequ est>) 140 void EmptyTextCheckerClient::requestCheckingOfString(PassRefPtrWillBeRawPtr<Text CheckingRequest>)
141 { 141 {
142 } 142 }
143 143
144 void EmptyFrameLoaderClient::didRequestAutocomplete(HTMLFormElement*) 144 void EmptyFrameLoaderClient::didRequestAutocomplete(HTMLFormElement*)
145 { 145 {
146 } 146 }
147 147
148 PassOwnPtr<blink::WebServiceWorkerProvider> EmptyFrameLoaderClient::createServic eWorkerProvider() 148 PassOwnPtr<blink::WebServiceWorkerProvider> EmptyFrameLoaderClient::createServic eWorkerProvider()
149 { 149 {
150 return nullptr; 150 return nullptr;
151 } 151 }
152 152
153 PassOwnPtr<blink::WebApplicationCacheHost> EmptyFrameLoaderClient::createApplica tionCacheHost(blink::WebApplicationCacheHostClient*) 153 PassOwnPtr<blink::WebApplicationCacheHost> EmptyFrameLoaderClient::createApplica tionCacheHost(blink::WebApplicationCacheHostClient*)
154 { 154 {
155 return nullptr; 155 return nullptr;
156 } 156 }
157 157
158 PassOwnPtr<StorageNamespace> EmptyStorageClient::createSessionStorageNamespace() 158 PassOwnPtr<StorageNamespace> EmptyStorageClient::createSessionStorageNamespace()
159 { 159 {
160 return nullptr; 160 return nullptr;
161 } 161 }
162 162
163 } 163 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698