Source/core/inspector/ConsoleMessageStorage.h - Issue 517043003: Move Frame to the Oilpan heap.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/inspector/ConsoleMessageStorage.h

Issue 517043003: Move Frame to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Back out non-Oilpan experiment + tidy up by adding frame() ref accessors Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« Source/core/html/HTMLFrameOwnerElement.cpp ('K') | « Source/core/html/parser/XSSAuditorDelegate.cpp ('k') | Source/core/inspector/ConsoleMessageStorage.cpp » ('j') | Source/core/loader/FrameLoader.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef ConsoleMessageStorage_h	5 #ifndef ConsoleMessageStorage_h

6 #define ConsoleMessageStorage_h	6 #define ConsoleMessageStorage_h

7	7

8 #include "core/inspector/ConsoleMessage.h"	8 #include "core/inspector/ConsoleMessage.h"

9 #include "platform/heap/Handle.h"	9 #include "platform/heap/Handle.h"

10 #include "wtf/Forward.h"	10 #include "wtf/Forward.h"

(...skipping 34 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
45	45

46 private:	46 private:

47 explicit ConsoleMessageStorage(ExecutionContext*);	47 explicit ConsoleMessageStorage(ExecutionContext*);

48 explicit ConsoleMessageStorage(LocalFrame*);	48 explicit ConsoleMessageStorage(LocalFrame*);

49	49

50 ExecutionContext* executionContext() const;	50 ExecutionContext* executionContext() const;

51	51

52 int m_expiredCount;	52 int m_expiredCount;

53 WillBeHeapDeque<RefPtrWillBeMember<ConsoleMessage> > m_messages;	53 WillBeHeapDeque<RefPtrWillBeMember<ConsoleMessage> > m_messages;

54 RawPtrWillBeMember<ExecutionContext> m_context;	54 RawPtrWillBeMember<ExecutionContext> m_context;

55 LocalFrame* m_frame;	55 RawPtrWillBeMember<LocalFrame> m_frame;

56 };	56 };

57	57

58 } // namespace blink	58 } // namespace blink

59	59

60 #endif // ConsoleMessageStorage_h	60 #endif // ConsoleMessageStorage_h

OLD	NEW