Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(766)

Side by Side Diff: Source/core/frame/Console.cpp

Issue 517043003: Move Frame to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Back out non-Oilpan experiment + tidy up by adding frame() ref accessors Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007 Apple Inc. All rights reserved. 2 * Copyright (C) 2007 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
56 } 56 }
57 57
58 void Console::trace(Visitor* visitor) 58 void Console::trace(Visitor* visitor)
59 { 59 {
60 ConsoleBase::trace(visitor); 60 ConsoleBase::trace(visitor);
61 DOMWindowProperty::trace(visitor); 61 DOMWindowProperty::trace(visitor);
62 } 62 }
63 63
64 ExecutionContext* Console::context() 64 ExecutionContext* Console::context()
65 { 65 {
66 if (!m_frame) 66 if (!frame())
67 return 0; 67 return 0;
68 return m_frame->document(); 68 return frame()->document();
69 } 69 }
70 70
71 void Console::reportMessageToConsole(PassRefPtrWillBeRawPtr<ConsoleMessage> cons oleMessage) 71 void Console::reportMessageToConsole(PassRefPtrWillBeRawPtr<ConsoleMessage> cons oleMessage)
72 { 72 {
73 if (!m_frame) 73 if (!frame())
74 return; 74 return;
75 75
76 m_frame->console().addMessage(consoleMessage); 76 frame()->console().addMessage(consoleMessage);
77 } 77 }
78 78
79 PassRefPtrWillBeRawPtr<MemoryInfo> Console::memory() const 79 PassRefPtrWillBeRawPtr<MemoryInfo> Console::memory() const
80 { 80 {
81 // FIXME: Because we create a new object here each time, 81 // FIXME: Because we create a new object here each time,
82 // console.memory !== console.memory, which seems wrong. 82 // console.memory !== console.memory, which seems wrong.
83 return MemoryInfo::create(); 83 return MemoryInfo::create();
84 } 84 }
85 85
86 } // namespace blink 86 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698