Source/core/inspector/ConsoleMessageStorage.cpp - Issue 517043003: Move Frame to the Oilpan heap.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/inspector/ConsoleMessageStorage.cpp

Issue 517043003: Move Frame to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add LocalFrame::detachView() + more Oilpan frame finalization comments Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "config.h"	5 #include "config.h"

6 #include "core/inspector/ConsoleMessageStorage.h"	6 #include "core/inspector/ConsoleMessageStorage.h"

7	7

8 #include "core/frame/LocalDOMWindow.h"	8 #include "core/frame/LocalDOMWindow.h"

9 #include "core/inspector/ConsoleMessage.h"	9 #include "core/inspector/ConsoleMessage.h"

10 #include "core/inspector/InspectorConsoleInstrumentation.h"	10 #include "core/inspector/InspectorConsoleInstrumentation.h"

(...skipping 80 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
91	91

92 ExecutionContext* ConsoleMessageStorage::executionContext() const	92 ExecutionContext* ConsoleMessageStorage::executionContext() const

93 {	93 {

94 return m_frame ? m_frame->document() : m_context;	94 return m_frame ? m_frame->document() : m_context;

95 }	95 }

96	96

97 void ConsoleMessageStorage::trace(Visitor* visitor)	97 void ConsoleMessageStorage::trace(Visitor* visitor)

98 {	98 {

99 visitor->trace(m_messages);	99 visitor->trace(m_messages);

100 visitor->trace(m_context);	100 visitor->trace(m_context);

	101 visitor->trace(m_frame);

101 }	102 }

102	103

103 } // namespace blink	104 } // namespace blink

OLD	NEW