Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Side by Side Diff: Source/core/frame/FrameView.cpp

Issue 517043003: Move Frame to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add LocalFrame::detachView() + more Oilpan frame finalization comments Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Dirk Mueller <mueller@kde.org> 5 * 2000 Dirk Mueller <mueller@kde.org>
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) 7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com)
8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * Copyright (C) 2009 Google Inc. All rights reserved. 9 * Copyright (C) 2009 Google Inc. All rights reserved.
10 * 10 *
(...skipping 2480 matching lines...) Expand 10 before | Expand all | Expand 10 after
2491 return; 2491 return;
2492 2492
2493 m_needsUpdateWidgetPositions = false; 2493 m_needsUpdateWidgetPositions = false;
2494 2494
2495 updateWidgetPositions(); 2495 updateWidgetPositions();
2496 } 2496 }
2497 2497
2498 void FrameView::updateLayoutAndStyleForPainting() 2498 void FrameView::updateLayoutAndStyleForPainting()
2499 { 2499 {
2500 // Updating layout can run script, which can tear down the FrameView. 2500 // Updating layout can run script, which can tear down the FrameView.
2501 RefPtr<FrameView> protector(this); 2501 RefPtr<FrameView> protect(this);
2502 2502
2503 updateLayoutAndStyleIfNeededRecursive(); 2503 updateLayoutAndStyleIfNeededRecursive();
2504 2504
2505 updateWidgetPositionsIfNeeded(); 2505 updateWidgetPositionsIfNeeded();
2506 2506
2507 RenderView* view = renderView(); 2507 RenderView* view = renderView();
2508 if (view) { 2508 if (view) {
2509 TRACE_EVENT_INSTANT1(TRACE_DISABLED_BY_DEFAULT("devtools.timeline"), "Up dateLayerTree", "frame", m_frame.get()); 2509 TRACE_EVENT_INSTANT1(TRACE_DISABLED_BY_DEFAULT("devtools.timeline"), "Up dateLayerTree", "frame", m_frame.get());
2510 // FIXME(361045): remove InspectorInstrumentation calls once DevTools Ti meline migrates to tracing. 2510 // FIXME(361045): remove InspectorInstrumentation calls once DevTools Ti meline migrates to tracing.
2511 InspectorInstrumentation::willUpdateLayerTree(m_frame.get()); 2511 InspectorInstrumentation::willUpdateLayerTree(m_frame.get());
(...skipping 452 matching lines...) Expand 10 before | Expand all | Expand 10 after
2964 void FrameView::willRemoveScrollbar(Scrollbar* scrollbar, ScrollbarOrientation o rientation) 2964 void FrameView::willRemoveScrollbar(Scrollbar* scrollbar, ScrollbarOrientation o rientation)
2965 { 2965 {
2966 ScrollableArea::willRemoveScrollbar(scrollbar, orientation); 2966 ScrollableArea::willRemoveScrollbar(scrollbar, orientation);
2967 if (AXObjectCache* cache = axObjectCache()) { 2967 if (AXObjectCache* cache = axObjectCache()) {
2968 cache->remove(scrollbar); 2968 cache->remove(scrollbar);
2969 cache->handleScrollbarUpdate(this); 2969 cache->handleScrollbarUpdate(this);
2970 } 2970 }
2971 } 2971 }
2972 2972
2973 } // namespace blink 2973 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698